Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
3ea9f791
Commit
3ea9f791
authored
Jun 17, 2013
by
Valera Rozuvan
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #179 from edx/valera/additional_comments_on_youtube_api_bug
Addtional comments for YouTube API bug.
parents
d1ebfbc9
184c0a5c
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
0 deletions
+6
-0
common/lib/xmodule/xmodule/js/src/videoalpha/display/video_player.coffee
+6
-0
No files found.
common/lib/xmodule/xmodule/js/src/videoalpha/display/video_player.coffee
View file @
3ea9f791
...
@@ -74,6 +74,9 @@ class @VideoPlayerAlpha extends SubviewAlpha
...
@@ -74,6 +74,9 @@ class @VideoPlayerAlpha extends SubviewAlpha
# when this change is requested (instead of simply requesting a speed change to 1.0). This has to
# when this change is requested (instead of simply requesting a speed change to 1.0). This has to
# be done only when the video is being watched in Firefox. We need to figure out what browser is
# be done only when the video is being watched in Firefox. We need to figure out what browser is
# currently executing this code.
# currently executing this code.
#
# TODO: Check the status of http://code.google.com/p/gdata-issues/issues/detail?id=4654
# When the YouTube team fixes the API bug, we can remove this temporary bug fix.
@
video
.
isFirefox
=
navigator
.
userAgent
.
toLowerCase
().
indexOf
(
'firefox'
)
>
-
1
@
video
.
isFirefox
=
navigator
.
userAgent
.
toLowerCase
().
indexOf
(
'firefox'
)
>
-
1
if
@
video
.
videoType
is
'html5'
if
@
video
.
videoType
is
'html5'
...
@@ -252,6 +255,9 @@ class @VideoPlayerAlpha extends SubviewAlpha
...
@@ -252,6 +255,9 @@ class @VideoPlayerAlpha extends SubviewAlpha
# or when we are in Firefox, and the new speed is 1.0. The second case is necessary to
# or when we are in Firefox, and the new speed is 1.0. The second case is necessary to
# avoid the bug where in Firefox speed switching to 1.0 in HTML5 player mode is handled
# avoid the bug where in Firefox speed switching to 1.0 in HTML5 player mode is handled
# incorrectly by YouTube API.
# incorrectly by YouTube API.
#
# TODO: Check the status of http://code.google.com/p/gdata-issues/issues/detail?id=4654
# When the YouTube team fixes the API bug, we can remove this temporary bug fix.
if
(
@
video
.
videoType
is
'youtube'
)
or
((
@
video
.
isFirefox
)
and
(
@
video
.
playerType
is
'youtube'
)
and
(
newSpeed
is
'1.0'
))
if
(
@
video
.
videoType
is
'youtube'
)
or
((
@
video
.
isFirefox
)
and
(
@
video
.
playerType
is
'youtube'
)
and
(
newSpeed
is
'1.0'
))
if
@
isPlaying
()
if
@
isPlaying
()
@
player
.
loadVideoById
(
@
video
.
youtubeId
(),
@
currentTime
)
@
player
.
loadVideoById
(
@
video
.
youtubeId
(),
@
currentTime
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment