consolidate the list of permissions

common/djangoapps/django_comment_common/utils.py

 from django_comment_common.models import Role
 
+_STUDENT_ROLE_PERMISSIONS = ["vote", "update_thread", "follow_thread", "unfollow_thread",
+                             "update_comment", "create_sub_comment", "unvote", "create_thread",
+                             "follow_commentable", "unfollow_commentable", "create_comment", ]
+
+_MODERATOR_ROLE_PERMISSIONS = ["edit_content", "delete_thread", "openclose_thread",
+                               "endorse_comment", "delete_comment", "see_all_cohorts"]
+
+_ADMINISTRATOR_ROLE_PERMISSIONS = ["manage_moderator"]
 
 def seed_permissions_roles(course_id):
     administrator_role = Role.objects.get_or_create(name="Administrator", course_id=course_id)[0]
@@ -7,16 +15,13 @@ def seed_permissions_roles(course_id):
     community_ta_role = Role.objects.get_or_create(name="Community TA", course_id=course_id)[0]
     student_role = Role.objects.get_or_create(name="Student", course_id=course_id)[0]
 
-    for per in ["vote", "update_thread", "follow_thread", "unfollow_thread",
-                "update_comment", "create_sub_comment", "unvote", "create_thread",
-                "follow_commentable", "unfollow_commentable", "create_comment", ]:
+    for per in _STUDENT_ROLE_PERMISSIONS:
         student_role.add_permission(per)
 
-    for per in ["edit_content", "delete_thread", "openclose_thread",
-                "endorse_comment", "delete_comment", "see_all_cohorts"]:
+    for per in _MODERATOR_ROLE_PERMISSIONS:
         moderator_role.add_permission(per)
 
-    for per in ["manage_moderator"]:
+    for per in _ADMINISTRATOR_ROLE_PERMISSIONS:
         administrator_role.add_permission(per)
 
     moderator_role.inherit_permissions(student_role)
@@ -36,18 +41,15 @@ def are_permissions_roles_seeded(course_id):
     except:
         return False
 
-    for per in ["vote", "update_thread", "follow_thread", "unfollow_thread",
-                "update_comment", "create_sub_comment", "unvote", "create_thread",
-                "follow_commentable", "unfollow_commentable", "create_comment", ]:
+    for per in _STUDENT_ROLE_PERMISSIONS:
         if not student_role.has_permission(per):
             return False
 
-    for per in ["edit_content", "delete_thread", "openclose_thread",
-                "endorse_comment", "delete_comment", "see_all_cohorts"]:
+    for per in _MODERATOR_ROLE_PERMISSIONS + _STUDENT_ROLE_PERMISSIONS:
         if not moderator_role.has_permission(per):
             return False
 
-    for per in ["manage_moderator"]:
+    for per in _ADMINISTRATOR_ROLE_PERMISSIONS + _MODERATOR_ROLE_PERMISSIONS + _STUDENT_ROLE_PERMISSIONS:
         if not administrator_role.has_permission(per):
             return False