Skip to content

E
edx-platform
Commit 34441759 by Brian Talbot
Options

settings - added in preventDefault() for all grading controls that needed it

parent 6b176591
Showing with 7 additions and 2 deletions
cms/static/js/views/settings/main_settings_view.js
...@@ -356,7 +356,8 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({ ...@@ -356,7 +356,8 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
return this; return this;
}, },
addAssignmentType : function() { addAssignmentType : function(e) {
e.preventDefault();
this.model.get('graders').push({}); this.model.get('graders').push({});
}, },
fieldToSelectorMap : { fieldToSelectorMap : {
...@@ -503,6 +504,7 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({ ...@@ -503,6 +504,7 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
}, },
addNewGrade: function(e) { addNewGrade: function(e) {
e.preventDefault();
var gradeLength = this.descendingCutoffs.length; // cutoffs doesn't include fail/f so this is only the passing grades var gradeLength = this.descendingCutoffs.length; // cutoffs doesn't include fail/f so this is only the passing grades
if(gradeLength > 3) { if(gradeLength > 3) {
// TODO shouldn't we disable the button // TODO shouldn't we disable the button
...@@ -541,6 +543,7 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({ ...@@ -541,6 +543,7 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
}, },
removeGrade: function(e) { removeGrade: function(e) {
e.preventDefault();
var domElement = $(e.currentTarget).closest('li'); var domElement = $(e.currentTarget).closest('li');
var index = domElement.index(); var index = domElement.index();
// copy the boundary up to the next higher grade then remove // copy the boundary up to the next higher grade then remove
...@@ -614,8 +617,9 @@ CMS.Views.Settings.GraderView = CMS.Views.ValidatingView.extend({ ...@@ -614,8 +617,9 @@ CMS.Views.Settings.GraderView = CMS.Views.ValidatingView.extend({
} }
}, },
deleteModel : function() { deleteModel : function(e) {
this.model.destroy(); this.model.destroy();
e.preventDefault();
} }
}); });
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment