Commit 3086f16d by Valera Rozuvan Committed by Vasyl Nakvasiuk

Added comment about enabling some Video Alpha tests when testing locally. Updated CHANGELOG.

parent b75876e3
...@@ -13,8 +13,12 @@ instance, Boolean, Integer, String), but also allow them to hold either the ...@@ -13,8 +13,12 @@ instance, Boolean, Integer, String), but also allow them to hold either the
typed value, or a String that can be converted to their typed value. For example, typed value, or a String that can be converted to their typed value. For example,
an Integer can contain 3 or '3'. This changed an update to the xblock library. an Integer can contain 3 or '3'. This changed an update to the xblock library.
<<<<<<< HEAD
LMS: Courses whose id matches a regex in the COURSES_WITH_UNSAFE_CODE Django LMS: Courses whose id matches a regex in the COURSES_WITH_UNSAFE_CODE Django
setting now run entirely outside the Python sandbox. setting now run entirely outside the Python sandbox.
=======
Blades: Added tests for Video Alpha player.
>>>>>>> 812be7a... Added comment about enabling some Video Alpha tests when testing locally. Updated CHANGELOG.
Blades: Video Alpha bug fix for speed changing to 1.0 in Firefox. Blades: Video Alpha bug fix for speed changing to 1.0 in Firefox.
......
...@@ -52,6 +52,16 @@ describe 'VideoAlpha HTML5Video', -> ...@@ -52,6 +52,16 @@ describe 'VideoAlpha HTML5Video', ->
it 'check if click event is handled on the player', -> it 'check if click event is handled on the player', ->
expect(@videoEl).toHandle 'click' expect(@videoEl).toHandle 'click'
# NOTE: According to
#
# https://github.com/ariya/phantomjs/wiki/Supported-Web-Standards#unsupported-features
#
# Video and Audio (due to the nature of PhantomJS) are not supported. After discussion
# with William Daly, some tests are disabled (Jenkins uses phantomjs for running tests
# and those tests fail).
#
# During code review, please enable the test below (change "xdescribe" to "describe"
# to enable the test).
xdescribe 'events:', -> xdescribe 'events:', ->
beforeEach -> beforeEach ->
...@@ -201,6 +211,16 @@ describe 'VideoAlpha HTML5Video', -> ...@@ -201,6 +211,16 @@ describe 'VideoAlpha HTML5Video', ->
jasmine.fireEvent @videoEl, "timeupdate" jasmine.fireEvent @videoEl, "timeupdate"
expect(@player.end).toBe @videoEl.duration expect(@player.end).toBe @videoEl.duration
# NOTE: According to
#
# https://github.com/ariya/phantomjs/wiki/Supported-Web-Standards#unsupported-features
#
# Video and Audio (due to the nature of PhantomJS) are not supported. After discussion
# with William Daly, some tests are disabled (Jenkins uses phantomjs for running tests
# and those tests fail).
#
# During code review, please enable the test below (change "xdescribe" to "describe"
# to enable the test).
xdescribe 'methods:', -> xdescribe 'methods:', ->
beforeEach -> beforeEach ->
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment