Addressed test failures and PR comments

TNL-5894

common/test/acceptance/pages/lms/course_info.py

@@ -20,7 +20,7 @@ class CourseInfoPage(CoursePage):
         """
         Return the number of updates on the page.
         """
-        return len(self.q(css='section.updates section article').results)
+        return len(self.q(css='.updates .updates-article').results)
 
     @property
     def handout_links(self):

lms/djangoapps/courseware/tests/test_course_info.py

@@ -216,15 +216,15 @@ class CourseInfoTitleTestCase(LoginEnrollmentTestCase, ModuleStoreTestCase):
         )
         self.assertIn(
             expected_title,
-            content('h1.page-title').contents()
+            content('.page-title').contents()[0]
         )
         self.assertIn(
             expected_display_title,
-            display_content('h1.page-title').contents()
+            display_content('.page-title').contents()[0]
         )
         self.assertIn(
             display_course.display_name_with_default,
-            display_content('h2.page-subtitle').contents()
+            display_content('.page-subtitle').contents()
         )
 
 

lms/djangoapps/courseware/tests/test_date_summary.py

@@ -180,7 +180,7 @@ class CourseDateSummaryTest(SharedModuleStoreTestCase):
         self.client.login(username='mrrobot', password='test')
 
         html_elements = [
-            '<h1 class="handouts-header">Important Course Dates</h1>',
+            '<h4 class="handouts-header">Important Course Dates</h4>',
             '<div class="date-summary-container">',
             '<div class="date-summary date-summary-todays-date">',
             '<h3 class="heading localized-datetime"',
@@ -202,7 +202,7 @@ class CourseDateSummaryTest(SharedModuleStoreTestCase):
         response = self.client.get(url)
 
         html_elements = [
-            '<h1 class="handouts-header">Important Course Dates</h1>',
+            '<h4 class="handouts-header">Important Course Dates</h4>',
             '<div class="date-summary-container">',
             '<div class="date-summary date-summary-todays-date">',
             '<h3 class="heading localized-datetime"',

lms/templates/courseware/course_updates.html

 <%! from django.utils.translation import ugettext as _ %>
-<div>
 <div class="recent-updates">
   % for index, update in enumerate(visible_updates):
     <article class="updates-article">
       % if not update.get("is_error"):
-        <div class="date" id="msg-date-${index}">${update.get("date")}</div>      
+        <h5 class="date" id="msg-date-${index}">${update.get("date")}</h5>
         <button
             class="toggle-visibility-button"
             data-hide="${_('Hide')}"
@@ -34,7 +33,7 @@
 <div class="old-updates hidden toggle-visibility-element" id="old-updates">
   % for index, update in enumerate(hidden_updates):
     <article class="updates-article">
-      <div class="date" id="msg-date-${index + len(visible_updates)}">${update.get("date")}</div>
+      <h5 class="date" id="msg-date-${index + len(visible_updates)}">${update.get("date")}</h5>
       <button
           class="toggle-visibility-button"
           data-hide="${_('Hide')}"
@@ -47,4 +46,3 @@
     </article>
   % endfor
 </div>
-<div>

lms/templates/courseware/info.html

@@ -91,10 +91,11 @@ from openedx.core.djangolib.markup import HTML, Text
             </div>
           % endif
         </section>
+
         <section aria-label="${_('Handout Navigation')}" class="handouts">
 
           % if SelfPacedConfiguration.current().enable_course_home_improvements:
-            <h4 class="handouts-header">${_("Important Course Dates")}</h1>
+                <h4 class="handouts-header">${_("Important Course Dates")}</h4>
                 ## Should be organized by date, last date appearing at the bottom
 
                 % for course_date in get_course_date_blocks(course, user):
@@ -122,20 +123,19 @@ from openedx.core.djangolib.markup import HTML, Text
                     </div>
                 % endfor
             % endif
-        <h1 class="handouts-header">${_(course.info_sidebar_name)}</h1>
+            <h4 class="handouts-header">${_(course.info_sidebar_name)}</h4>
             ${HTML(get_course_info_section(request, masquerade_user, course, 'handouts'))}
         </section>
       % else:
         <section class="updates">
-          <h1 class="handouts-header">${_("Course Updates and News")}</h1>
+          <h4 class="handouts-header">${_("Course Updates and News")}</h4>
           ${HTML(get_course_info_section(request, masquerade_user, course, 'guest_updates'))}
         </section>
         <section aria-label="${_('Handout Navigation')}" class="handouts">
-          <h1 class="handouts-header">${_("Course Handouts")}</h1>
+          <h4 class="handouts-header">${_("Course Handouts")}</h4>
           ${HTML(get_course_info_section(request, masquerade_user, course, 'guest_handouts'))}
         </section>
-
-    % endif
+      % endif <!-- if course authenticated -->
       </div>
   </div>
 </main>