LMS: removing conditional search Sass logic + simplifying _build-*.scss files

lms/static/sass/_build-course.scss

@@ -62,3 +62,6 @@
 
 // discussion
 @import "course/discussion/form-wmd-toolbar";
+
+// search
+@import 'search/_search';

lms/static/sass/_build-lms.scss

@@ -68,4 +68,12 @@
 @import 'discussion/utilities/developer';
 @import 'discussion/utilities/shame';
 
+// search
+@import 'search/_search';
+
+// news
 @import 'news';
+
+// overrides
+@import 'developer'; // used for any developer-created scss that needs further polish/refactoring
+@import 'shame';     // used for any bad-form/orphaned scss

lms/static/sass/application-rtl.scss.mako

@@ -30,12 +30,3 @@
 
 @import 'build-lms'; // shared app style assets/rendering
 
-## Import styles for search
-% if env["FEATURES"].get("ENABLE_DASHBOARD_SEARCH", False):
-  @import 'search/_search';
-% endif
-
-@import 'developer'; // used for any developer-created scss that needs further polish/refactoring
-@import 'shame';     // used for any bad-form/orphaned scss
-## NOTE: needed here for cascade and dependency purposes, but not a great permanent solution
-

lms/static/sass/application.scss.mako

@@ -29,12 +29,3 @@
 % endif
 
 @import 'build-lms'; // shared app style assets/rendering
-
-## Import styles for search
-% if env["FEATURES"].get("ENABLE_DASHBOARD_SEARCH", False):
-  @import 'search/_search';
-% endif
-
-@import 'developer'; // used for any developer-created scss that needs further polish/refactoring
-@import 'shame';     // used for any bad-form/orphaned scss
-## NOTE: needed here for cascade and dependency purposes, but not a great permanent solution

lms/static/sass/course-rtl.scss.mako

@@ -20,8 +20,3 @@
 % endif
 
 @import 'build-course'; // shared app style assets/rendering
-
-## Import styles for search
-% if env["FEATURES"].get("ENABLE_COURSEWARE_SEARCH"):
-    @import 'search/_search';
-% endif

lms/static/sass/course.scss.mako

@@ -20,8 +20,3 @@
 % endif
 
 @import 'build-course'; // shared app style assets/rendering
-
-## Import styles for search
-% if env["FEATURES"].get("ENABLE_COURSEWARE_SEARCH"):
-    @import 'search/_search';
-% endif