diff --git a/common/lib/xmodule/xmodule/tests/xml/test_inheritance.py b/common/lib/xmodule/xmodule/tests/xml/test_inheritance.py index dc27f0c..e922b47 100644 --- a/common/lib/xmodule/xmodule/tests/xml/test_inheritance.py +++ b/common/lib/xmodule/xmodule/tests/xml/test_inheritance.py @@ -1,10 +1,10 @@ """ Test that inherited fields work correctly when parsing XML """ -from nose.tools import assert_equals # pylint: disable=no-name-in-module +from nose.tools import assert_equals, assert_in # pylint: disable=no-name-in-module from xmodule.tests.xml import XModuleXmlImportTest -from xmodule.tests.xml.factories import CourseFactory, SequenceFactory, ProblemFactory +from xmodule.tests.xml.factories import CourseFactory, SequenceFactory, ProblemFactory, XmlImportFactory class TestInheritedFieldParsing(XModuleXmlImportTest): @@ -27,3 +27,21 @@ class TestInheritedFieldParsing(XModuleXmlImportTest): problem = sequence.get_children()[0] assert_equals(None, problem.days_early_for_beta) + + def test_video_attr(self): + """ + Test that video's definition_from_xml handles unknown attrs w/o choking + """ + # Fixes LMS-11491 + root = CourseFactory.build() + sequence = SequenceFactory.build(parent=root) + video = XmlImportFactory( + parent=sequence, + tag='video', + attribs={ + 'parent_sequential_url': 'foo', 'garbage': 'asdlk', + 'download_video': 'true', + } + ) + video_block = self.process_xml(video) + assert_in('garbage', video_block.xml_attributes)