Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
1d07b278
Commit
1d07b278
authored
Aug 21, 2015
by
Chris Rodriguez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Test fixes
parent
a31eb4a8
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
16 additions
and
20 deletions
+16
-20
common/test/acceptance/pages/lms/course_nav.py
+6
-6
common/test/acceptance/pages/lms/courseware.py
+2
-2
common/test/acceptance/tests/lms/test_lms.py
+1
-1
lms/static/js/fixtures/accordion.html
+6
-6
lms/static/js/utils/navigation.js
+1
-5
No files found.
common/test/acceptance/pages/lms/course_nav.py
View file @
1d07b278
...
@@ -82,7 +82,7 @@ class CourseNavPage(PageObject):
...
@@ -82,7 +82,7 @@ class CourseNavPage(PageObject):
# Click the section to ensure it's open (no harm in clicking twice if it's already open)
# Click the section to ensure it's open (no harm in clicking twice if it's already open)
# Add one to convert from list index to CSS index
# Add one to convert from list index to CSS index
section_css
=
'nav>
div
.chapter:nth-of-type({0})'
.
format
(
sec_index
+
1
)
section_css
=
'nav>.chapter:nth-of-type({0})'
.
format
(
sec_index
+
1
)
self
.
q
(
css
=
section_css
)
.
first
.
click
()
self
.
q
(
css
=
section_css
)
.
first
.
click
()
# Get the subsection by index
# Get the subsection by index
...
@@ -94,7 +94,7 @@ class CourseNavPage(PageObject):
...
@@ -94,7 +94,7 @@ class CourseNavPage(PageObject):
return
return
# Convert list indices (start at zero) to CSS indices (start at 1)
# Convert list indices (start at zero) to CSS indices (start at 1)
subsection_css
=
"nav>
div.chapter-content-container:nth-of-type({0})>div>ol>li
:nth-of-type({1})>a"
.
format
(
subsection_css
=
"nav>
.chapter-content-container:nth-of-type({0})>.chapter-menu
:nth-of-type({1})>a"
.
format
(
sec_index
+
1
,
subsec_index
+
1
sec_index
+
1
,
subsec_index
+
1
)
)
...
@@ -130,7 +130,7 @@ class CourseNavPage(PageObject):
...
@@ -130,7 +130,7 @@ class CourseNavPage(PageObject):
"""
"""
Return a list of all section titles on the page.
Return a list of all section titles on the page.
"""
"""
chapter_css
=
'nav >
button.chapter > h3
'
chapter_css
=
'nav >
.chapter > .group-heading
'
return
self
.
q
(
css
=
chapter_css
)
.
map
(
lambda
el
:
el
.
text
.
strip
())
.
results
return
self
.
q
(
css
=
chapter_css
)
.
map
(
lambda
el
:
el
.
text
.
strip
())
.
results
def
_subsection_titles
(
self
,
section_index
):
def
_subsection_titles
(
self
,
section_index
):
...
@@ -140,7 +140,7 @@ class CourseNavPage(PageObject):
...
@@ -140,7 +140,7 @@ class CourseNavPage(PageObject):
"""
"""
# Retrieve the subsection title for the section
# Retrieve the subsection title for the section
# Add one to the list index to get the CSS index, which starts at one
# Add one to the list index to get the CSS index, which starts at one
subsection_css
=
'nav>.chapter-content-container:nth-of-type({0})>
div>ol>li
>a>p:nth-of-type(1)'
.
format
(
subsection_css
=
'nav>.chapter-content-container:nth-of-type({0})>
.chapter-menu
>a>p:nth-of-type(1)'
.
format
(
section_index
section_index
)
)
...
@@ -173,8 +173,8 @@ class CourseNavPage(PageObject):
...
@@ -173,8 +173,8 @@ class CourseNavPage(PageObject):
That's true right after we click the section/subsection, but not true in general
That's true right after we click the section/subsection, but not true in general
(the user could go to a section, then expand another tab).
(the user could go to a section, then expand another tab).
"""
"""
current_section_list
=
self
.
q
(
css
=
'nav>
button.chapter.is-open>h3
'
)
.
text
current_section_list
=
self
.
q
(
css
=
'nav>
.chapter.is-open>.group-heading
'
)
.
text
current_subsection_list
=
self
.
q
(
css
=
'nav
div.chapter-content-container ol li.active>a
>p'
)
.
text
current_subsection_list
=
self
.
q
(
css
=
'nav
.chapter-content-container a.active
>p'
)
.
text
if
len
(
current_section_list
)
==
0
:
if
len
(
current_section_list
)
==
0
:
self
.
warning
(
"Could not find the current section"
)
self
.
warning
(
"Could not find the current section"
)
...
...
common/test/acceptance/pages/lms/courseware.py
View file @
1d07b278
...
@@ -14,7 +14,7 @@ class CoursewarePage(CoursePage):
...
@@ -14,7 +14,7 @@ class CoursewarePage(CoursePage):
url_path
=
"courseware/"
url_path
=
"courseware/"
xblock_component_selector
=
'.vert .xblock'
xblock_component_selector
=
'.vert .xblock'
section_selector
=
'.chapter'
section_selector
=
'.chapter'
subsection_selector
=
'.chapter-content-container
ol li
'
subsection_selector
=
'.chapter-content-container
.chapter-menu a
'
def
is_browser_on_page
(
self
):
def
is_browser_on_page
(
self
):
return
self
.
q
(
css
=
'body.courseware'
)
.
present
return
self
.
q
(
css
=
'body.courseware'
)
.
present
...
@@ -102,7 +102,7 @@ class CoursewarePage(CoursePage):
...
@@ -102,7 +102,7 @@ class CoursewarePage(CoursePage):
"""
"""
return the url of the active subsection in the left nav
return the url of the active subsection in the left nav
"""
"""
return
self
.
q
(
css
=
'.chapter-content-container
ol li.active a
'
)
.
attrs
(
'href'
)[
0
]
return
self
.
q
(
css
=
'.chapter-content-container
.chapter-menu a.active
'
)
.
attrs
(
'href'
)[
0
]
@property
@property
def
can_start_proctored_exam
(
self
):
def
can_start_proctored_exam
(
self
):
...
...
common/test/acceptance/tests/lms/test_lms.py
View file @
1d07b278
...
@@ -1121,7 +1121,7 @@ class EntranceExamTest(UniqueCourseTest):
...
@@ -1121,7 +1121,7 @@ class EntranceExamTest(UniqueCourseTest):
When I view the courseware that has an entrance exam
When I view the courseware that has an entrance exam
Then there should be an "Entrance Exam" chapter.'
Then there should be an "Entrance Exam" chapter.'
"""
"""
entrance_exam_link_selector
=
'
div#accordion nav button h3
'
entrance_exam_link_selector
=
'
#accordion nav .chapter .group-heading
'
# visit courseware page and make sure there is not entrance exam chapter.
# visit courseware page and make sure there is not entrance exam chapter.
self
.
courseware_page
.
visit
()
self
.
courseware_page
.
visit
()
self
.
courseware_page
.
wait_for_page
()
self
.
courseware_page
.
wait_for_page
()
...
...
lms/static/js/fixtures/accordion.html
View file @
1d07b278
...
@@ -10,14 +10,14 @@
...
@@ -10,14 +10,14 @@
</button>
</button>
<div
class=
"chapter-content-container"
tabindex=
"-1"
aria-expanded=
"true"
>
<div
class=
"chapter-content-container"
tabindex=
"-1"
aria-expanded=
"true"
>
<div
class=
"chapter-menu"
id=
"accordion-menu-1"
>
<div
class=
"chapter-menu"
id=
"accordion-menu-1"
>
<a
href=
"
http://www.edx.org
"
>
<a
href=
"
#
"
>
<p>
edX Homepage
</p>
<p>
edX Homepage
</p>
<p
class=
"subtitle"
>
Ungraded
</p>
<p
class=
"subtitle"
>
Ungraded
</p>
</a>
</a>
<a
class=
"active"
href=
"
http://blog.edx.org
"
>
<a
class=
"active"
href=
"
#
"
>
<p>
The edX Blog
</p>
<p>
The edX Blog
</p>
</a>
</a>
<a
class=
"graded"
href=
"
http://courses.edx.org
"
>
<a
class=
"graded"
href=
"
#
"
>
<p>
Courses Dashboard
</p>
<p>
Courses Dashboard
</p>
<p
class=
"subtitle"
>
Graded
</p>
<p
class=
"subtitle"
>
Graded
</p>
</a>
</a>
...
@@ -30,14 +30,14 @@
...
@@ -30,14 +30,14 @@
</button>
</button>
<div
class=
"chapter-content-container"
tabindex=
"-1"
aria-expanded=
"false"
>
<div
class=
"chapter-content-container"
tabindex=
"-1"
aria-expanded=
"false"
>
<div
class=
"chapter-menu"
id=
"accordion-menu-2"
>
<div
class=
"chapter-menu"
id=
"accordion-menu-2"
>
<a
href=
"
http://www.edx.org
"
>
<a
href=
"
#
"
>
<p>
edX Homepage
</p>
<p>
edX Homepage
</p>
<p
class=
"subtitle"
>
Ungraded
</p>
<p
class=
"subtitle"
>
Ungraded
</p>
</a>
</a>
<a
href=
"
http://blog.edx.org
"
>
<a
href=
"
#
"
>
<p>
The edX Blog
</p>
<p>
The edX Blog
</p>
</a>
</a>
<a
class=
"graded"
href=
"
http://courses.edx.org
"
>
<a
class=
"graded"
href=
"
#
"
>
<p>
Courses Dashboard
</p>
<p>
Courses Dashboard
</p>
<p
class=
"subtitle"
>
Graded
</p>
<p
class=
"subtitle"
>
Graded
</p>
</a>
</a>
...
...
lms/static/js/utils/navigation.js
View file @
1d07b278
...
@@ -25,11 +25,7 @@ var edx = edx || {},
...
@@ -25,11 +25,7 @@ var edx = edx || {},
active
=
$
(
'#accordion div div:has(a.active)'
).
index
(
'#accordion div div'
);
active
=
$
(
'#accordion div div:has(a.active)'
).
index
(
'#accordion div div'
);
if
(
active
<
0
)
{
if
(
typeof
active
===
'undefined'
||
active
<
0
)
{
active
=
$
(
'#accordion group-heading.active'
).
index
(
'#accordion h3'
);
}
if
(
active
<
0
)
{
active
=
0
;
active
=
0
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment