Commit 1528cd19 by Victor Shnayder

Merge pull request #900 from MITx/feature/ichuang-fix-capa_module-reset-string-bug

reset_problem in capa_module should always return dicts not strings
parents 2ba11c92 b0318b36
...@@ -624,12 +624,14 @@ class CapaModule(XModule): ...@@ -624,12 +624,14 @@ class CapaModule(XModule):
if self.closed(): if self.closed():
event_info['failure'] = 'closed' event_info['failure'] = 'closed'
self.system.track_function('reset_problem_fail', event_info) self.system.track_function('reset_problem_fail', event_info)
return "Problem is closed" return {'success': False,
'error': "Problem is closed"}
if not self.lcp.done: if not self.lcp.done:
event_info['failure'] = 'not_done' event_info['failure'] = 'not_done'
self.system.track_function('reset_problem_fail', event_info) self.system.track_function('reset_problem_fail', event_info)
return "Refresh the page and make an attempt before resetting." return {'success': False,
'error': "Refresh the page and make an attempt before resetting."}
self.lcp.do_reset() self.lcp.do_reset()
if self.rerandomize in ["always", "onreset"]: if self.rerandomize in ["always", "onreset"]:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment