Commit 86802c1a by Gabe Mulley

Remove a SELECT 1 query

Change-Id: I304bc445c5bb0fad123535eebfa1a3d69c6800fb
parent e0fe7588
...@@ -39,19 +39,14 @@ class BaseCourseView(generics.ListAPIView): ...@@ -39,19 +39,14 @@ class BaseCourseView(generics.ListAPIView):
return super(BaseCourseView, self).get(request, *args, **kwargs) return super(BaseCourseView, self).get(request, *args, **kwargs)
def verify_course_exists_or_404(self, course_id):
if self.model.objects.filter(course_id=course_id).exists():
return True
raise Http404
def apply_date_filtering(self, queryset): def apply_date_filtering(self, queryset):
raise NotImplementedError raise NotImplementedError
def get_queryset(self): def get_queryset(self):
self.verify_course_exists_or_404(self.course_id)
queryset = self.model.objects.filter(course_id=self.course_id) queryset = self.model.objects.filter(course_id=self.course_id)
queryset = self.apply_date_filtering(queryset) queryset = self.apply_date_filtering(queryset)
if not queryset:
raise Http404
return queryset return queryset
def get_csv_filename(self): def get_csv_filename(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment