Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
f126856f
Commit
f126856f
authored
Feb 27, 2014
by
Dustin Farris
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow 'None' to pass as a null value in RelatedFields
parent
505f1173
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
5 deletions
+6
-5
rest_framework/relations.py
+3
-2
rest_framework/tests/test_nullable_fields.py
+3
-3
No files found.
rest_framework/relations.py
View file @
f126856f
...
...
@@ -33,6 +33,7 @@ class RelatedField(WritableField):
many_widget
=
widgets
.
SelectMultiple
form_field_class
=
forms
.
ChoiceField
many_form_field_class
=
forms
.
MultipleChoiceField
null_values
=
(
None
,
''
,
'None'
)
cache_choices
=
False
empty_label
=
None
...
...
@@ -168,9 +169,9 @@ class RelatedField(WritableField):
return
value
=
[]
if
self
.
many
else
None
if
value
in
(
None
,
''
)
and
self
.
required
:
if
value
in
self
.
null_values
:
if
self
.
required
:
raise
ValidationError
(
self
.
error_messages
[
'required'
])
elif
value
in
(
None
,
''
):
into
[(
self
.
source
or
field_name
)]
=
None
elif
self
.
many
:
into
[(
self
.
source
or
field_name
)]
=
[
self
.
from_native
(
item
)
for
item
in
value
]
...
...
rest_framework/tests/test_nullable_fields.py
View file @
f126856f
...
...
@@ -15,12 +15,12 @@ urlpatterns = patterns(
class
NullableForeignKeyTests
(
APITestCase
):
"""
DRF should be able to handle nullable f
ields when a TestClien
t
POST/PUT request is made with its own serialized object.
DRF should be able to handle nullable f
oreign keys when a tes
t
Client
POST/PUT request is made with its own serialized object.
"""
urls
=
'rest_framework.tests.test_nullable_fields'
def
test_updating_object_with_null_f
ield_value
(
self
):
def
test_updating_object_with_null_f
k
(
self
):
obj
=
NullableForeignKeySource
(
name
=
'example'
,
target
=
None
)
obj
.
save
()
serialized_data
=
NullableFKSourceSerializer
(
obj
)
.
data
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment