Commit d4f5fe99 by Tom Christie

Merge pull request #1078 from yprez/fix_1072

Fix empty serializer bug
parents ec689c1e 745ebeca
...@@ -264,7 +264,7 @@ class PrimaryKeyRelatedField(RelatedField): ...@@ -264,7 +264,7 @@ class PrimaryKeyRelatedField(RelatedField):
# RelatedObject (reverse relationship) # RelatedObject (reverse relationship)
try: try:
pk = getattr(obj, self.source or field_name).pk pk = getattr(obj, self.source or field_name).pk
except ObjectDoesNotExist: except (ObjectDoesNotExist, AttributeError):
return None return None
# Forward relationship # Forward relationship
......
...@@ -283,6 +283,15 @@ class PKForeignKeyTests(TestCase): ...@@ -283,6 +283,15 @@ class PKForeignKeyTests(TestCase):
self.assertFalse(serializer.is_valid()) self.assertFalse(serializer.is_valid())
self.assertEqual(serializer.errors, {'target': ['This field is required.']}) self.assertEqual(serializer.errors, {'target': ['This field is required.']})
def test_foreign_key_with_empty(self):
"""
Regression test for #1072
https://github.com/tomchristie/django-rest-framework/issues/1072
"""
serializer = NullableForeignKeySourceSerializer()
self.assertEqual(serializer.data['target'], None)
class PKNullableForeignKeyTests(TestCase): class PKNullableForeignKeyTests(TestCase):
def setUp(self): def setUp(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment