Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
d4f5fe99
Commit
d4f5fe99
authored
Sep 02, 2013
by
Tom Christie
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1078 from yprez/fix_1072
Fix empty serializer bug
parents
ec689c1e
745ebeca
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletions
+10
-1
rest_framework/relations.py
+1
-1
rest_framework/tests/test_relations_pk.py
+9
-0
No files found.
rest_framework/relations.py
View file @
d4f5fe99
...
...
@@ -264,7 +264,7 @@ class PrimaryKeyRelatedField(RelatedField):
# RelatedObject (reverse relationship)
try
:
pk
=
getattr
(
obj
,
self
.
source
or
field_name
)
.
pk
except
ObjectDoesNotExist
:
except
(
ObjectDoesNotExist
,
AttributeError
)
:
return
None
# Forward relationship
...
...
rest_framework/tests/test_relations_pk.py
View file @
d4f5fe99
...
...
@@ -283,6 +283,15 @@ class PKForeignKeyTests(TestCase):
self
.
assertFalse
(
serializer
.
is_valid
())
self
.
assertEqual
(
serializer
.
errors
,
{
'target'
:
[
'This field is required.'
]})
def
test_foreign_key_with_empty
(
self
):
"""
Regression test for #1072
https://github.com/tomchristie/django-rest-framework/issues/1072
"""
serializer
=
NullableForeignKeySourceSerializer
()
self
.
assertEqual
(
serializer
.
data
[
'target'
],
None
)
class
PKNullableForeignKeyTests
(
TestCase
):
def
setUp
(
self
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment