Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
c3fd7c66
Commit
c3fd7c66
authored
May 20, 2013
by
David Jones
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated SlugField to raise validation errors for invalid slugs
parent
ee543e46
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
29 additions
and
0 deletions
+29
-0
rest_framework/fields.py
+14
-0
rest_framework/tests/fields.py
+15
-0
No files found.
rest_framework/fields.py
View file @
c3fd7c66
...
@@ -389,10 +389,24 @@ class URLField(CharField):
...
@@ -389,10 +389,24 @@ class URLField(CharField):
class
SlugField
(
CharField
):
class
SlugField
(
CharField
):
type_name
=
'SlugField'
type_name
=
'SlugField'
form_field_class
=
forms
.
SlugField
default_error_messages
=
{
'invalid'
:
_
(
"Enter a valid 'slug' consisting of letters, numbers,"
" underscores or hyphens."
),
}
default_validators
=
[
validators
.
validate_slug
]
def
__init__
(
self
,
*
args
,
**
kwargs
):
def
__init__
(
self
,
*
args
,
**
kwargs
):
super
(
SlugField
,
self
)
.
__init__
(
*
args
,
**
kwargs
)
super
(
SlugField
,
self
)
.
__init__
(
*
args
,
**
kwargs
)
def
__deepcopy__
(
self
,
memo
):
result
=
copy
.
copy
(
self
)
memo
[
id
(
self
)]
=
result
#result.widget = copy.deepcopy(self.widget, memo)
result
.
validators
=
self
.
validators
[:]
return
result
class
ChoiceField
(
WritableField
):
class
ChoiceField
(
WritableField
):
type_name
=
'ChoiceField'
type_name
=
'ChoiceField'
...
...
rest_framework/tests/fields.py
View file @
c3fd7c66
...
@@ -769,6 +769,21 @@ class SlugFieldTests(TestCase):
...
@@ -769,6 +769,21 @@ class SlugFieldTests(TestCase):
self
.
assertEqual
(
serializer
.
is_valid
(),
True
)
self
.
assertEqual
(
serializer
.
is_valid
(),
True
)
self
.
assertEqual
(
getattr
(
serializer
.
fields
[
'slug_field'
],
'max_length'
),
20
)
self
.
assertEqual
(
getattr
(
serializer
.
fields
[
'slug_field'
],
'max_length'
),
20
)
def
test_invalid_slug
(
self
):
"""
Make sure an invalid slug raises ValidationError
"""
class
SlugFieldSerializer
(
serializers
.
ModelSerializer
):
slug_field
=
serializers
.
SlugField
(
source
=
'slug_field'
,
max_length
=
20
,
required
=
True
)
class
Meta
:
model
=
self
.
SlugFieldModel
s
=
SlugFieldSerializer
(
data
=
{
'slug_field'
:
'a b'
})
self
.
assertEqual
(
s
.
is_valid
(),
False
)
self
.
assertEqual
(
s
.
errors
,
{
'slug_field'
:
[
"Enter a valid 'slug' consisting of letters, numbers, underscores or hyphens."
]})
class
URLFieldTests
(
TestCase
):
class
URLFieldTests
(
TestCase
):
"""
"""
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment