Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
c3644234
Commit
c3644234
authored
Nov 20, 2012
by
Mark Aaron Shirley
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add support for partial serializer updates
parent
d22daa04
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
3 deletions
+16
-3
rest_framework/fields.py
+2
-2
rest_framework/serializers.py
+2
-1
rest_framework/tests/serializer.py
+12
-0
No files found.
rest_framework/fields.py
View file @
c3644234
...
...
@@ -148,7 +148,7 @@ class WritableField(Field):
self
.
widget
=
widget
def
validate
(
self
,
value
):
if
value
in
validators
.
EMPTY_VALUES
and
self
.
required
:
if
value
in
validators
.
EMPTY_VALUES
and
self
.
required
and
not
self
.
root
.
partial
:
raise
ValidationError
(
self
.
error_messages
[
'required'
])
def
run_validators
(
self
,
value
):
...
...
@@ -186,7 +186,7 @@ class WritableField(Field):
if
self
.
default
is
not
None
:
native
=
self
.
default
else
:
if
self
.
required
:
if
self
.
required
and
not
self
.
root
.
partial
:
raise
ValidationError
(
self
.
error_messages
[
'required'
])
return
...
...
rest_framework/serializers.py
View file @
c3644234
...
...
@@ -91,12 +91,13 @@ class BaseSerializer(Field):
_options_class
=
SerializerOptions
_dict_class
=
SortedDictWithMetadata
# Set to unsorted dict for backwards compatibility with unsorted implementations.
def
__init__
(
self
,
instance
=
None
,
data
=
None
,
files
=
None
,
context
=
None
,
**
kwargs
):
def
__init__
(
self
,
instance
=
None
,
data
=
None
,
files
=
None
,
context
=
None
,
partial
=
False
,
**
kwargs
):
super
(
BaseSerializer
,
self
)
.
__init__
(
**
kwargs
)
self
.
opts
=
self
.
_options_class
(
self
.
Meta
)
self
.
fields
=
copy
.
deepcopy
(
self
.
base_fields
)
self
.
parent
=
None
self
.
root
=
None
self
.
partial
=
partial
self
.
context
=
context
or
{}
...
...
rest_framework/tests/serializer.py
View file @
c3644234
...
...
@@ -108,6 +108,18 @@ class BasicTests(TestCase):
self
.
assertTrue
(
serializer
.
object
is
expected
)
self
.
assertEquals
(
serializer
.
data
[
'sub_comment'
],
'And Merry Christmas!'
)
def
test_partial_update
(
self
):
msg
=
'Merry New Year!'
partial_data
=
{
'content'
:
msg
}
serializer
=
CommentSerializer
(
self
.
comment
,
data
=
partial_data
)
self
.
assertEquals
(
serializer
.
is_valid
(),
False
)
serializer
=
CommentSerializer
(
self
.
comment
,
data
=
partial_data
,
partial
=
True
)
expected
=
self
.
comment
self
.
assertEqual
(
serializer
.
is_valid
(),
True
)
self
.
assertEquals
(
serializer
.
object
,
expected
)
self
.
assertTrue
(
serializer
.
object
is
expected
)
self
.
assertEquals
(
serializer
.
data
[
'content'
],
msg
)
def
test_model_fields_as_expected
(
self
):
"""
Make sure that the fields returned are the same as defined
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment