Commit 69fea562 by Tom Christie

Merge pull request #2401 from jpadilla/master

Fix ident format when using HTTP_X_FORWARDED_FOR
parents e9ac1bb7 cc13ee05
...@@ -32,10 +32,10 @@ class BaseThrottle(object): ...@@ -32,10 +32,10 @@ class BaseThrottle(object):
if num_proxies == 0 or xff is None: if num_proxies == 0 or xff is None:
return remote_addr return remote_addr
addrs = xff.split(',') addrs = xff.split(',')
client_addr = addrs[-min(num_proxies, len(xff))] client_addr = addrs[-min(num_proxies, len(addrs))]
return client_addr.strip() return client_addr.strip()
return xff if xff else remote_addr return ''.join(xff.split()) if xff else remote_addr
def wait(self): def wait(self):
""" """
...@@ -173,12 +173,6 @@ class AnonRateThrottle(SimpleRateThrottle): ...@@ -173,12 +173,6 @@ class AnonRateThrottle(SimpleRateThrottle):
if request.user.is_authenticated(): if request.user.is_authenticated():
return None # Only throttle unauthenticated requests. return None # Only throttle unauthenticated requests.
ident = request.META.get('HTTP_X_FORWARDED_FOR')
if ident is None:
ident = request.META.get('REMOTE_ADDR')
else:
ident = ''.join(ident.split())
return self.cache_format % { return self.cache_format % {
'scope': self.scope, 'scope': self.scope,
'ident': self.get_ident(request) 'ident': self.get_ident(request)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment