Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
20d1fdba
Commit
20d1fdba
authored
Feb 16, 2016
by
Carlton Gibson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix None UUID ForeignKey serialization
parent
79dad012
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
38 additions
and
1 deletions
+38
-1
docs/topics/release-notes.md
+1
-0
rest_framework/fields.py
+2
-0
tests/models.py
+15
-0
tests/test_relations_pk.py
+20
-1
No files found.
docs/topics/release-notes.md
View file @
20d1fdba
...
@@ -45,6 +45,7 @@ You can determine your currently installed version using `pip freeze`:
...
@@ -45,6 +45,7 @@ You can determine your currently installed version using `pip freeze`:
*
*Unreleased
**
*
*Unreleased
**
*
Dropped support for EOL Django 1.7 ([#3933][gh3933])
*
Dropped support for EOL Django 1.7 ([#3933][gh3933])
*
Fixed
null
foreign keys targeting UUIDField primary keys. ([#3936][gh3936])
### 3.3.2
### 3.3.2
...
...
rest_framework/fields.py
View file @
20d1fdba
...
@@ -778,6 +778,8 @@ class UUIDField(Field):
...
@@ -778,6 +778,8 @@ class UUIDField(Field):
return
data
return
data
def
to_representation
(
self
,
value
):
def
to_representation
(
self
,
value
):
if
value
is
None
:
return
None
if
self
.
uuid_format
==
'hex_verbose'
:
if
self
.
uuid_format
==
'hex_verbose'
:
return
str
(
value
)
return
str
(
value
)
else
:
else
:
...
...
tests/models.py
View file @
20d1fdba
from
__future__
import
unicode_literals
from
__future__
import
unicode_literals
import
uuid
from
django.db
import
models
from
django.db
import
models
from
django.utils.translation
import
ugettext_lazy
as
_
from
django.utils.translation
import
ugettext_lazy
as
_
...
@@ -46,6 +48,11 @@ class ForeignKeyTarget(RESTFrameworkModel):
...
@@ -46,6 +48,11 @@ class ForeignKeyTarget(RESTFrameworkModel):
name
=
models
.
CharField
(
max_length
=
100
)
name
=
models
.
CharField
(
max_length
=
100
)
class
UUIDForeignKeyTarget
(
RESTFrameworkModel
):
uuid
=
models
.
UUIDField
(
primary_key
=
True
,
default
=
uuid
.
uuid4
)
name
=
models
.
CharField
(
max_length
=
100
)
class
ForeignKeySource
(
RESTFrameworkModel
):
class
ForeignKeySource
(
RESTFrameworkModel
):
name
=
models
.
CharField
(
max_length
=
100
)
name
=
models
.
CharField
(
max_length
=
100
)
target
=
models
.
ForeignKey
(
ForeignKeyTarget
,
related_name
=
'sources'
,
target
=
models
.
ForeignKey
(
ForeignKeyTarget
,
related_name
=
'sources'
,
...
@@ -62,6 +69,14 @@ class NullableForeignKeySource(RESTFrameworkModel):
...
@@ -62,6 +69,14 @@ class NullableForeignKeySource(RESTFrameworkModel):
on_delete
=
models
.
CASCADE
)
on_delete
=
models
.
CASCADE
)
class
NullableUUIDForeignKeySource
(
RESTFrameworkModel
):
name
=
models
.
CharField
(
max_length
=
100
)
target
=
models
.
ForeignKey
(
ForeignKeyTarget
,
null
=
True
,
blank
=
True
,
related_name
=
'nullable_sources'
,
verbose_name
=
'Optional target object'
,
on_delete
=
models
.
CASCADE
)
# OneToOne
# OneToOne
class
OneToOneTarget
(
RESTFrameworkModel
):
class
OneToOneTarget
(
RESTFrameworkModel
):
name
=
models
.
CharField
(
max_length
=
100
)
name
=
models
.
CharField
(
max_length
=
100
)
...
...
tests/test_relations_pk.py
View file @
20d1fdba
...
@@ -6,7 +6,8 @@ from django.utils import six
...
@@ -6,7 +6,8 @@ from django.utils import six
from
rest_framework
import
serializers
from
rest_framework
import
serializers
from
tests.models
import
(
from
tests.models
import
(
ForeignKeySource
,
ForeignKeyTarget
,
ManyToManySource
,
ManyToManyTarget
,
ForeignKeySource
,
ForeignKeyTarget
,
ManyToManySource
,
ManyToManyTarget
,
NullableForeignKeySource
,
NullableOneToOneSource
,
OneToOneTarget
NullableForeignKeySource
,
NullableOneToOneSource
,
NullableUUIDForeignKeySource
,
OneToOneTarget
,
UUIDForeignKeyTarget
)
)
...
@@ -43,6 +44,18 @@ class NullableForeignKeySourceSerializer(serializers.ModelSerializer):
...
@@ -43,6 +44,18 @@ class NullableForeignKeySourceSerializer(serializers.ModelSerializer):
fields
=
(
'id'
,
'name'
,
'target'
)
fields
=
(
'id'
,
'name'
,
'target'
)
# Nullable UUIDForeignKey
class
NullableUUIDForeignKeySourceSerializer
(
serializers
.
ModelSerializer
):
target
=
serializers
.
PrimaryKeyRelatedField
(
pk_field
=
serializers
.
UUIDField
(),
queryset
=
UUIDForeignKeyTarget
.
objects
.
all
(),
allow_empty
=
True
)
class
Meta
:
model
=
NullableUUIDForeignKeySource
fields
=
(
'id'
,
'name'
,
'target'
)
# Nullable OneToOne
# Nullable OneToOne
class
NullableOneToOneTargetSerializer
(
serializers
.
ModelSerializer
):
class
NullableOneToOneTargetSerializer
(
serializers
.
ModelSerializer
):
class
Meta
:
class
Meta
:
...
@@ -432,6 +445,12 @@ class PKNullableForeignKeyTests(TestCase):
...
@@ -432,6 +445,12 @@ class PKNullableForeignKeyTests(TestCase):
]
]
self
.
assertEqual
(
serializer
.
data
,
expected
)
self
.
assertEqual
(
serializer
.
data
,
expected
)
def
test_null_uuid_foreign_key_serializes_as_none
(
self
):
source
=
NullableUUIDForeignKeySource
(
name
=
'Source'
)
serializer
=
NullableUUIDForeignKeySourceSerializer
(
source
)
data
=
serializer
.
data
self
.
assertEqual
(
data
[
"target"
],
None
)
class
PKNullableOneToOneTests
(
TestCase
):
class
PKNullableOneToOneTests
(
TestCase
):
def
setUp
(
self
):
def
setUp
(
self
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment