Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
1ddfef12
Commit
1ddfef12
authored
Apr 12, 2015
by
Tymur Maryokhin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Removed deprecated '.model' attribute check
parent
970bfe16
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
19 deletions
+10
-19
rest_framework/permissions.py
+10
-19
No files found.
rest_framework/permissions.py
View file @
1ddfef12
...
...
@@ -77,7 +77,7 @@ class DjangoModelPermissions(BasePermission):
`add`/`change`/`delete` permissions on the model.
This permission can only be applied against view classes that
provide a `.
model` or `.
queryset` attribute.
provide a `.queryset` attribute.
"""
# Map methods into required permission codes.
...
...
@@ -107,24 +107,19 @@ class DjangoModelPermissions(BasePermission):
return
[
perm
%
kwargs
for
perm
in
self
.
perms_map
[
method
]]
def
has_permission
(
self
,
request
,
view
):
# Note that `.model` attribute on views is deprecated, although we
# enforce the deprecation on the view `get_serializer_class()` and
# `get_queryset()` methods, rather than here.
model_cls
=
getattr
(
view
,
'model'
,
None
)
queryset
=
getattr
(
view
,
'queryset'
,
None
)
if
model_cls
is
None
and
queryset
is
not
None
:
model_cls
=
queryset
.
model
# Workaround to ensure DjangoModelPermissions are not applied
# to the root view when using DefaultRouter.
if
model_cls
is
None
and
getattr
(
view
,
'_ignore_model_permissions'
,
False
):
if
queryset
is
None
and
getattr
(
view
,
'_ignore_model_permissions'
,
False
):
return
True
assert
model_cls
,
(
'Cannot apply DjangoModelPermissions on a view that'
' does not have `.model` or `.queryset` property.'
)
assert
queryset
,
(
'Cannot apply DjangoModelPermissions on a view that '
'does not have `.queryset` property.'
)
perms
=
self
.
get_required_permissions
(
request
.
method
,
model_cls
)
perms
=
self
.
get_required_permissions
(
request
.
method
,
queryset
.
model
)
return
(
request
.
user
and
...
...
@@ -150,7 +145,7 @@ class DjangoObjectPermissions(DjangoModelPermissions):
`add`/`change`/`delete` permissions on the object using .has_perms.
This permission can only be applied against view classes that
provide a `.
model` or `.
queryset` attribute.
provide a `.queryset` attribute.
"""
perms_map
=
{
...
...
@@ -171,14 +166,10 @@ class DjangoObjectPermissions(DjangoModelPermissions):
return
[
perm
%
kwargs
for
perm
in
self
.
perms_map
[
method
]]
def
has_object_permission
(
self
,
request
,
view
,
obj
):
model_cls
=
getattr
(
view
,
'model'
,
None
)
queryset
=
getattr
(
view
,
'queryset'
,
None
)
if
model_cls
is
None
and
queryset
is
not
None
:
model_cls
=
queryset
.
model
model_cls
=
view
.
queryset
.
model
user
=
request
.
user
perms
=
self
.
get_required_object_permissions
(
request
.
method
,
model_cls
)
user
=
request
.
user
if
not
user
.
has_perms
(
perms
,
obj
):
# If the user does not have permissions we need to determine if
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment