Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
D
django-rest-framework
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
django-rest-framework
Commits
07efbdb4
Commit
07efbdb4
authored
Sep 02, 2016
by
Mathieu Pillard
Committed by
Tom Christie
Sep 02, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix APIClient.get() when path contains unicode arguments (#4458)
parent
80bd3b97
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
3 deletions
+13
-3
rest_framework/test.py
+6
-3
tests/test_testing.py
+7
-0
No files found.
rest_framework/test.py
View file @
07efbdb4
...
@@ -79,10 +79,13 @@ class APIRequestFactory(DjangoRequestFactory):
...
@@ -79,10 +79,13 @@ class APIRequestFactory(DjangoRequestFactory):
r
=
{
r
=
{
'QUERY_STRING'
:
urlencode
(
data
or
{},
doseq
=
True
),
'QUERY_STRING'
:
urlencode
(
data
or
{},
doseq
=
True
),
}
}
# Fix to support old behavior where you have the arguments in the url
# See #1461
if
not
data
and
'?'
in
path
:
if
not
data
and
'?'
in
path
:
r
[
'QUERY_STRING'
]
=
path
.
split
(
'?'
)[
1
]
# Fix to support old behavior where you have the arguments in the
# url. See #1461.
query_string
=
force_bytes
(
path
.
split
(
'?'
)[
1
])
if
six
.
PY3
:
query_string
=
query_string
.
decode
(
'iso-8859-1'
)
r
[
'QUERY_STRING'
]
=
query_string
r
.
update
(
extra
)
r
.
update
(
extra
)
return
self
.
generic
(
'GET'
,
path
,
**
r
)
return
self
.
generic
(
'GET'
,
path
,
**
r
)
...
...
tests/test_testing.py
View file @
07efbdb4
...
@@ -245,3 +245,10 @@ class TestAPIRequestFactory(TestCase):
...
@@ -245,3 +245,10 @@ class TestAPIRequestFactory(TestCase):
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'test'
]})
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'test'
]})
request
=
factory
.
get
(
'/view/'
,
{
'demo'
:
'test'
})
request
=
factory
.
get
(
'/view/'
,
{
'demo'
:
'test'
})
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'test'
]})
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'test'
]})
def
test_request_factory_url_arguments_with_unicode
(
self
):
factory
=
APIRequestFactory
()
request
=
factory
.
get
(
'/view/?demo=testé'
)
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'testé'
]})
request
=
factory
.
get
(
'/view/'
,
{
'demo'
:
'testé'
})
self
.
assertEqual
(
dict
(
request
.
GET
),
{
'demo'
:
[
'testé'
]})
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment