Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
cs_comments_service
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
cs_comments_service
Commits
9f0bbe59
Commit
9f0bbe59
authored
Nov 01, 2012
by
arjun810
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #11 from rll/feature/kevin/edit_commentable_id
Feature/kevin/edit commentable
parents
6650a39d
9105ab17
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
2 deletions
+4
-2
api/comment_threads.rb
+2
-1
spec/api/comment_thread_spec.rb
+2
-1
No files found.
api/comment_threads.rb
View file @
9f0bbe59
...
@@ -14,11 +14,12 @@ get "#{APIPREFIX}/threads/:thread_id" do |thread_id|
...
@@ -14,11 +14,12 @@ get "#{APIPREFIX}/threads/:thread_id" do |thread_id|
end
end
put
"
#{
APIPREFIX
}
/threads/:thread_id"
do
|
thread_id
|
put
"
#{
APIPREFIX
}
/threads/:thread_id"
do
|
thread_id
|
thread
.
update_attributes
(
params
.
slice
(
*
%w[title body closed]
))
thread
.
update_attributes
(
params
.
slice
(
*
%w[title body closed
commentable_id
]
))
if
params
[
"tags"
]
if
params
[
"tags"
]
thread
.
tags
=
params
[
"tags"
]
thread
.
tags
=
params
[
"tags"
]
thread
.
save
thread
.
save
end
end
if
thread
.
errors
.
any?
if
thread
.
errors
.
any?
error
400
,
thread
.
errors
.
full_messages
.
to_json
error
400
,
thread
.
errors
.
full_messages
.
to_json
else
else
...
...
spec/api/comment_thread_spec.rb
View file @
9f0bbe59
...
@@ -57,11 +57,12 @@ describe "app" do
...
@@ -57,11 +57,12 @@ describe "app" do
describe
"PUT /api/v1/threads/:thread_id"
do
describe
"PUT /api/v1/threads/:thread_id"
do
it
"update information of comment thread"
do
it
"update information of comment thread"
do
thread
=
CommentThread
.
first
thread
=
CommentThread
.
first
put
"/api/v1/threads/
#{
thread
.
id
}
"
,
body:
"new body"
,
title:
"new title"
put
"/api/v1/threads/
#{
thread
.
id
}
"
,
body:
"new body"
,
title:
"new title"
,
commentable_id:
"new_commentable_id"
last_response
.
should
be_ok
last_response
.
should
be_ok
changed_thread
=
CommentThread
.
find
(
thread
.
id
)
changed_thread
=
CommentThread
.
find
(
thread
.
id
)
changed_thread
.
body
.
should
==
"new body"
changed_thread
.
body
.
should
==
"new body"
changed_thread
.
title
.
should
==
"new title"
changed_thread
.
title
.
should
==
"new title"
changed_thread
.
commentable_id
.
should
==
"new commentable_id"
end
end
it
"returns 400 when the thread does not exist"
do
it
"returns 400 when the thread does not exist"
do
put
"/api/v1/threads/does_not_exist"
,
body:
"new body"
,
title:
"new title"
put
"/api/v1/threads/does_not_exist"
,
body:
"new body"
,
title:
"new title"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment