Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
cs_comments_service
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
cs_comments_service
Commits
81dca823
Commit
81dca823
authored
Sep 23, 2012
by
Ibrahim Awwal
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make handle_threads_query scope all queries by course_id so that everything that uses it is scoped.
parent
236ff613
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
2 deletions
+3
-2
api/comment_threads.rb
+0
-0
api/notifications_and_subscriptions.rb
+1
-1
lib/helpers.rb
+2
-1
No files found.
api/comment_threads.rb
View file @
81dca823
api/notifications_and_subscriptions.rb
View file @
81dca823
...
@@ -3,7 +3,7 @@ get "#{APIPREFIX}/users/:user_id/notifications" do |user_id|
...
@@ -3,7 +3,7 @@ get "#{APIPREFIX}/users/:user_id/notifications" do |user_id|
end
end
get
"
#{
APIPREFIX
}
/users/:user_id/subscribed_threads"
do
|
user_id
|
get
"
#{
APIPREFIX
}
/users/:user_id/subscribed_threads"
do
|
user_id
|
handle_threads_query
(
user
.
subscribed_threads
.
where
(
:course_id
=>
params
[
:course_id
])
)
handle_threads_query
(
user
.
subscribed_threads
)
end
end
post
"
#{
APIPREFIX
}
/users/:user_id/subscriptions"
do
|
user_id
|
post
"
#{
APIPREFIX
}
/users/:user_id/subscriptions"
do
|
user_id
|
...
...
lib/helpers.rb
View file @
81dca823
...
@@ -76,7 +76,7 @@ helpers do
...
@@ -76,7 +76,7 @@ helpers do
end
end
def
handle_threads_query
(
comment_threads
)
def
handle_threads_query
(
comment_threads
)
comment_threads
=
comment_threads
.
where
(
:course_id
=>
params
[
:course_id
])
if
CommentService
.
config
[
:cache_enabled
]
if
CommentService
.
config
[
:cache_enabled
]
query_params
=
params
.
slice
(
*
%w[course_id commentable_id sort_key sort_order page per_page user_id]
)
query_params
=
params
.
slice
(
*
%w[course_id commentable_id sort_key sort_order page per_page user_id]
)
memcached_key
=
"threads_query_
#{
query_params
.
hash
}
"
memcached_key
=
"threads_query_
#{
query_params
.
hash
}
"
...
@@ -105,6 +105,7 @@ helpers do
...
@@ -105,6 +105,7 @@ helpers do
sort_key
=
sort_key_mapper
[
params
[
"sort_key"
]]
sort_key
=
sort_key_mapper
[
params
[
"sort_key"
]]
sort_order
=
sort_order_mapper
[
params
[
"sort_order"
]]
sort_order
=
sort_order_mapper
[
params
[
"sort_order"
]]
sort_keyword_valid
=
(
!
params
[
"sort_key"
]
&&
!
params
[
"sort_order"
]
||
sort_key
&&
sort_order
)
sort_keyword_valid
=
(
!
params
[
"sort_key"
]
&&
!
params
[
"sort_order"
]
||
sort_key
&&
sort_order
)
if
not
sort_keyword_valid
if
not
sort_keyword_valid
{}.
to_json
{}.
to_json
else
else
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment