Short Description Source Fix

Source the proper short description from Marketing Site course about pages into discovery service
LEARNER-3379

course_discovery/apps/course_metadata/data_loaders/marketing_site.py

@@ -464,7 +464,8 @@ class CourseMarketingSiteDataLoader(AbstractMarketingSiteDataLoader):
             'mobile_available': data.get('field_course_enrollment_mobile') or False,
             'video': course.video,
             'course': course,
-            'short_description_override': self.clean_html(data['field_course_sub_title_short']) or None,
+            # We want to consume the same value for the override here to stay consistent with the marketing site
+            'short_description_override': self.clean_html(data['field_course_sub_title_long']['value']) or None,
             'min_effort': min_effort,
             'max_effort': max_effort,
             'outcome': (data.get('field_course_what_u_will_learn', {}) or {}).get('value')
@@ -489,7 +490,7 @@ class CourseMarketingSiteDataLoader(AbstractMarketingSiteDataLoader):
             'number': data['field_course_code'],
             'full_description': self.get_description(data),
             'video': self.get_video(data),
-            'short_description': self.clean_html(data['field_course_sub_title_short']),
+            'short_description': self.clean_html(data['field_course_sub_title_long']['value']),
             'level_type': self.get_level_type(data['field_course_level']),
             'card_image_url': self._get_nested_url(data.get('field_course_image_promoted')),
             'outcome': (data.get('field_course_what_u_will_learn', {}) or {}).get('value'),

course_discovery/apps/course_metadata/data_loaders/tests/test_marketing_site.py

@@ -476,7 +476,7 @@ class CourseMarketingSiteDataLoaderTests(AbstractMarketingSiteDataLoaderTestMixi
             'number': data['field_course_code'],
             'full_description': self.loader.get_description(data),
             'video': self.loader.get_video(data),
-            'short_description': self.loader.clean_html(data['field_course_sub_title_short']),
+            'short_description': self.loader.clean_html(data['field_course_sub_title_long']['value']),
             'level_type': self.loader.get_level_type(data['field_course_level']),
             'card_image_url': (data.get('field_course_image_promoted') or {}).get('url'),
             'outcome': (data.get('field_course_what_u_will_learn', {}) or {}).get('value'),
@@ -537,7 +537,7 @@ class CourseMarketingSiteDataLoaderTests(AbstractMarketingSiteDataLoaderTestMixi
             'pacing_type': self.loader.get_pacing_type(data),
             'hidden': self.loader.get_hidden(data),
             'mobile_available': data['field_course_enrollment_mobile'] or False,
-            'short_description_override': self.loader.clean_html(data['field_course_sub_title_short']) or None,
+            'short_description_override': self.loader.clean_html(data['field_course_sub_title_long']['value']) or None,
             'outcome': (data.get('field_course_what_u_will_learn', {}) or {}).get('value'),
         }