Fixed course-run send for review if seat type is credit.

LEARNER-1250

course_discovery/apps/publisher/models.py

@@ -329,7 +329,7 @@ class CourseRun(TimeStampedModel, ChangedByMixin):
         """
         Validate course-run has a  valid seats.
         """
-        seats = self.seats.filter(type__in=[Seat.AUDIT, Seat.VERIFIED, Seat.PROFESSIONAL])
+        seats = self.seats.filter(type__in=[Seat.AUDIT, Seat.VERIFIED, Seat.PROFESSIONAL, Seat.CREDIT])
         return all([seat.is_valid_seat for seat in seats]) if seats else False
 
 
@@ -379,7 +379,7 @@ class Seat(TimeStampedModel, ChangedByMixin):
         return (
             self.type == self.AUDIT or
             (self.type in [self.VERIFIED, self.PROFESSIONAL] and self.price > 0) or
-            (self.type == self.CREDIT and self.credit_price > 0)
+            (self.type == self.CREDIT and self.credit_price > 0 and self.price > 0)
         )
 
 

course_discovery/apps/publisher/tests/test_model.py

@@ -123,6 +123,15 @@ class CourseRunTests(TestCase):
 
         self.assertTrue(self.course_run.has_valid_seats)
 
+        credit_seat = factories.SeatFactory(course_run=self.course_run, type=Seat.CREDIT, price=0, credit_price=0)
+        self.assertFalse(self.course_run.has_valid_seats)
+
+        credit_seat.price = 200
+        credit_seat.credit_price = 200
+        credit_seat.save()
+
+        self.assertTrue(self.course_run.has_valid_seats)
+
 
 class CourseTests(TestCase):
     """ Tests for the publisher `Course` model. """