Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
course-discovery
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
course-discovery
Commits
838d3330
Commit
838d3330
authored
Sep 19, 2016
by
Renzo Lucioni
Committed by
GitHub
Sep 19, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Exclude hidden runs from search results (#342)
ECOM-5689.
parent
482d0c0c
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
2 deletions
+16
-2
course_discovery/apps/api/v1/tests/test_views/test_search.py
+14
-0
course_discovery/apps/api/v1/views.py
+2
-2
No files found.
course_discovery/apps/api/v1/tests/test_views/test_search.py
View file @
838d3330
...
...
@@ -197,6 +197,20 @@ class AggregateSearchViewSet(DefaultPartnerMixin, SerializationMixin, LoginMixin
self
.
assertListEqual
(
response_data
[
'objects'
][
'results'
],
[
self
.
serialize_course_run
(
course_run
),
self
.
serialize_program
(
program
)])
def
test_hidden_runs_excluded
(
self
):
"""Search results should not include hidden runs."""
visible_run
=
CourseRunFactory
(
course__partner
=
self
.
partner
)
hidden_run
=
CourseRunFactory
(
course__partner
=
self
.
partner
,
hidden
=
True
)
self
.
assertEqual
(
CourseRun
.
objects
.
get
(
hidden
=
True
),
hidden_run
)
response
=
self
.
get_search_response
()
data
=
json
.
loads
(
response
.
content
.
decode
(
'utf-8'
))
self
.
assertEqual
(
data
[
'objects'
][
'results'
],
[
self
.
serialize_course_run
(
visible_run
)]
)
def
test_results_filtered_by_default_partner
(
self
):
""" Verify the search results only include items related to the default partner if no partner is
specified on the request. If a partner is included, the data should be filtered to the requested partner. """
...
...
course_discovery/apps/api/v1/views.py
View file @
838d3330
...
...
@@ -572,8 +572,8 @@ class BaseHaystackViewSet(FacetMixin, HaystackViewSet):
facet_serializer_cls
=
self
.
get_facet_serializer_class
()
field_queries
=
getattr
(
facet_serializer_cls
.
Meta
,
'field_queries'
,
{})
# Ensure we only return published items
queryset
=
queryset
.
filter
(
published
=
True
)
# Ensure we only return published
, non-hidden
items
queryset
=
queryset
.
filter
(
published
=
True
)
.
exclude
(
hidden
=
True
)
for
facet
in
self
.
request
.
query_params
.
getlist
(
'selected_query_facets'
):
query
=
field_queries
.
get
(
facet
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment