Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
C
course-discovery
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
course-discovery
Commits
7dab67de
Commit
7dab67de
authored
Sep 19, 2016
by
Renzo Lucioni
Committed by
GitHub
Sep 19, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ingest the hidden field from Drupal if the partner has a marketing site. (#339)
ECOM-5688.
parent
2abcd409
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
0 deletions
+23
-0
course_discovery/apps/course_metadata/data_loaders/marketing_site.py
+6
-0
course_discovery/apps/course_metadata/data_loaders/tests/test_marketing_site.py
+17
-0
No files found.
course_discovery/apps/course_metadata/data_loaders/marketing_site.py
View file @
7dab67de
...
...
@@ -426,6 +426,11 @@ class CourseMarketingSiteDataLoader(AbstractMarketingSiteDataLoader):
self_paced
=
data
.
get
(
'field_course_self_paced'
,
False
)
return
CourseRunPacing
.
Self
if
self_paced
else
CourseRunPacing
.
Instructor
def
get_hidden
(
self
,
data
):
# 'couse' [sic]. The field is misspelled on Drupal. ಠ_ಠ
hidden
=
data
.
get
(
'field_couse_is_hidden'
,
False
)
return
hidden
is
True
def
create_course_run
(
self
,
course
,
data
):
uuid
=
data
[
'uuid'
]
key
=
data
[
'field_course_id'
]
...
...
@@ -446,6 +451,7 @@ class CourseMarketingSiteDataLoader(AbstractMarketingSiteDataLoader):
'status'
:
self
.
get_course_run_status
(
data
),
'start'
:
start
,
'pacing_type'
:
self
.
get_pacing_type
(
data
),
'hidden'
:
self
.
get_hidden
(
data
),
}
try
:
...
...
course_discovery/apps/course_metadata/data_loaders/tests/test_marketing_site.py
View file @
7dab67de
...
...
@@ -372,6 +372,22 @@ class CourseMarketingSiteDataLoaderTests(AbstractMarketingSiteDataLoaderTestMixi
self
.
assertEqual
(
self
.
loader
.
get_course_run_status
(
data
),
expected
)
@ddt.data
(
(
True
,
True
),
(
'foo'
,
False
),
(
''
,
False
),
(
None
,
False
),
)
@ddt.unpack
def
test_get_hidden
(
self
,
hidden
,
expected
):
"""Verify that the get_hidden method returns the correct Boolean value."""
data
=
{
'field_couse_is_hidden'
:
hidden
}
self
.
assertEqual
(
self
.
loader
.
get_hidden
(
data
),
expected
)
def
test_get_hidden_missing
(
self
):
"""Verify that the get_hidden method can cope with a missing field."""
self
.
assertEqual
(
self
.
loader
.
get_hidden
({}),
False
)
@ddt.data
(
{
'field_course_body'
:
{
'value'
:
'Test'
}},
{
'field_course_description'
:
{
'value'
:
'Test'
}},
{
'field_course_description'
:
{
'value'
:
'Test2'
},
'field_course_body'
:
{
'value'
:
'Test'
}},
...
...
@@ -464,6 +480,7 @@ class CourseMarketingSiteDataLoaderTests(AbstractMarketingSiteDataLoaderTestMixi
'status'
:
self
.
loader
.
get_course_run_status
(
data
),
'start'
:
start
,
'pacing_type'
:
self
.
loader
.
get_pacing_type
(
data
),
'hidden'
:
self
.
loader
.
get_hidden
(
data
),
}
for
field
,
value
in
expected_values
.
items
():
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment