Fix instructor bio editing capability for all internal users.

course_discovery/apps/course_metadata/lookups.py

@@ -72,7 +72,8 @@ class PersonAutocomplete(LoginRequiredMixin, autocomplete.Select2QuerySetView):
                 'profile_image': result.get_profile_image_url,
                 'full_name': result.full_name,
                 'position': result.position if hasattr(result, 'position') else None,
-                'organization_id': result.position.organization_id if hasattr(result, 'position') else None
+                'organization_id': result.position.organization_id if hasattr(result, 'position') else None,
+                'can_edit_instructor': not result.profile_image_url,
 
             }
 

course_discovery/apps/publisher/forms.py

@@ -29,6 +29,7 @@ class PersonModelMultipleChoice(forms.ModelMultipleChoiceField):
         context = {
             'profile_image': obj.get_profile_image_url,
             'full_name': obj.full_name,
+            'can_edit_instructor': not obj.profile_image_url,
             'uuid': obj.uuid,
             'organization_id': obj.position.organization_id if hasattr(obj, 'position') else None
         }

course_discovery/apps/publisher/templates/publisher/_personFieldLabel.html

-<img src="{{ profile_image }}"/><span{% if uuid %} data-uuid="{{ uuid }}" {% endif %}>{{ full_name }}</span>{% if organization_id %}<span>{{ organization_id }}</span>{% endif %}
+<img src="{{ profile_image }}"/><span{% if can_edit_instructor %}  data-can-edit="{{ can_edit_instructor }}" {% endif %} data-uuid="{{ uuid }}" >{{ full_name }}</span>{% if organization_id %}<span>{{ organization_id }}</span>{% endif %}

course_discovery/apps/publisher/templates/publisher/_personLookup.html

-<table class="instructor-option" id="{{ uuid }}">
+<table class="instructor-option" id="{{ uuid }}" {% if can_edit_instructor %}  data-can-edit="{{ can_edit_instructor }}" {% endif %}>
   <tr>
     <td><img src="{{ profile_image }}" alt="profile image"/></td>
     <td>

course_discovery/static/js/publisher/instructors.js

@@ -6,8 +6,9 @@ $(document).ready(function(){
             image_source = $(label[0]).attr('src'),
             name = $(label[1]).text(),
             uuid = $(label[1]).data('uuid'),
-            organization_id = $(label[2]).text();
-        renderSelectedInstructor(id, name, image_source, uuid, organization_id);
+            organization_id = $(label[2]).text(),
+            edit_instructor = $(label[1]).data('can-edit');
+        renderSelectedInstructor(id, name, image_source, uuid, organization_id, edit_instructor);
     });
 
     $("#id_staff").on("select2:select", function(e) {
@@ -17,8 +18,9 @@ $(document).ready(function(){
             image_source = $(selectedInstructorData).find('img').attr('src'),

             name = $(selectedInstructorData).find('b').text(),
             uuid = $(selectedInstructorData)[0].id,
-            organization_id = $(selectedInstructorData).find('span').text();
-        renderSelectedInstructor(id, name, image_source, uuid, organization_id);
+            organization_id = $(selectedInstructorData).find('span').text(),
+            edit_instructor = $(selectedInstructorData).data('can-edit');
+        renderSelectedInstructor(id, name, image_source, uuid, organization_id, edit_instructor);
 
     });
 
@@ -139,7 +141,7 @@ $(document).on('click', '.selected-instructor a.delete', function (e) {
     $('.instructor-select').find('.select2-selection__choice').remove();
 });
 
-function renderSelectedInstructor(id, name, image, uuid, organization_id) {
+function renderSelectedInstructor(id, name, image, uuid, organization_id, edit_instructor) {
     var user_organizations_ids = $('#user_organizations_ids').text(),
         course_user_role = $('#course_user_role').text(),
         instructorHtmlStart = '<div class="instructor" id= "instructor_'+ id +'"><div><img src="' + image + '"></div><div>',
@@ -152,6 +154,11 @@ function renderSelectedInstructor(id, name, image, uuid, organization_id) {
                 controlOptions += '<a class="edit" id="' + uuid + '"href="#"><i class="fa fa-pencil-square-o fa-fw"></i></a>';
             }
     }
+    else {
+        if (edit_instructor){
+            controlOptions += '<a class="edit" id="' + uuid + '"href="#"><i class="fa fa-pencil-square-o fa-fw"></i></a>';
+        }
+    }
     $('.selected-instructor').append(instructorHtmlStart + controlOptions + instructorHtmlEnd);
 }
 
@@ -182,7 +189,9 @@ function loadInstructor(uuid, editMode) {
         label,
         image_source,
         name,
-        instructor_id;
+        instructor_id,
+        organization_id,
+        edit_instructor;
 
     $.getJSON({
         url: url,
@@ -198,7 +207,8 @@ function loadInstructor(uuid, editMode) {
                     value: id,
                     text: name
                 }).attr('selected', 'selected'));
-                organization_id = $(label).find('span').text()
+                organization_id = $(label).find('span').text();
+                edit_instructor = $(label).data('can-edit');
 
                 if (editMode) {
                     // Updating the existing instructor
@@ -207,7 +217,7 @@ function loadInstructor(uuid, editMode) {
                     instructor_id.find('b').text(name);
                 }
                 else {
-                    renderSelectedInstructor(id, name, image_source, uuid, organization_id);
+                    renderSelectedInstructor(id, name, image_source, uuid, organization_id, edit_instructor);
                 }
             }