Commit 2d625f67 by tasawernawaz Committed by Tasawer Nawaz

No need to send comment emails to the person entering the comments

ECOM-7727
parent 75c7325d
...@@ -63,6 +63,11 @@ def send_email_for_comment(comment, created=False): ...@@ -63,6 +63,11 @@ def send_email_for_comment(comment, created=False):
course_name = course.title course_name = course.title
to_addresses = course.get_course_users_emails() to_addresses = course.get_course_users_emails()
# remove email of comment owner if exists
if comment.user_email in to_addresses:
to_addresses.remove(comment.user_email)
from_address = settings.PUBLISHER_FROM_EMAIL from_address = settings.PUBLISHER_FROM_EMAIL
context = { context = {
......
...@@ -126,7 +126,7 @@ class CommentsEmailTests(TestCase): ...@@ -126,7 +126,7 @@ class CommentsEmailTests(TestCase):
def assert_comment_email_sent(self, content_object, comment, object_path, subject): def assert_comment_email_sent(self, content_object, comment, object_path, subject):
""" DRY method to assert send email data""" """ DRY method to assert send email data"""
self.assertEqual([self.user.email, self.user_2.email], mail.outbox[0].to) self.assertEqual([self.user_2.email], mail.outbox[0].to)
self.assertEqual(str(mail.outbox[0].subject), subject) self.assertEqual(str(mail.outbox[0].subject), subject)
body = mail.outbox[0].body.strip() body = mail.outbox[0].body.strip()
if isinstance(content_object, CourseRun): if isinstance(content_object, CourseRun):
...@@ -160,7 +160,7 @@ class CommentsEmailTests(TestCase): ...@@ -160,7 +160,7 @@ class CommentsEmailTests(TestCase):
) )
self.create_comment(content_object=self.course_run) self.create_comment(content_object=self.course_run)
self.assertEqual(len(mail.outbox), 1) self.assertEqual(len(mail.outbox), 1)
self.assertEqual([self.user.email, self.user_2.email, user_4.email, user_5.email], mail.outbox[0].to) self.assertEqual([self.user_2.email, user_4.email, user_5.email], mail.outbox[0].to)
def test_email_for_roles_only(self): def test_email_for_roles_only(self):
""" Verify the emails send to the course roles users even if groups has no users. """ """ Verify the emails send to the course roles users even if groups has no users. """
...@@ -255,7 +255,7 @@ class CommentsEmailTests(TestCase): ...@@ -255,7 +255,7 @@ class CommentsEmailTests(TestCase):
def create_comment(self, content_object, comment_type=CommentTypeChoices.Default): def create_comment(self, content_object, comment_type=CommentTypeChoices.Default):
""" DRY method to create the comment for a given content type.""" """ DRY method to create the comment for a given content type."""
return CommentFactory( return CommentFactory(
content_object=content_object, user=self.user, site=self.site, content_object=content_object, user=self.user, site=self.site, user_email=self.user.email,
comment_type=comment_type comment_type=comment_type
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment