Merge pull request #1537 from edx/import-later

Ignore import errors until we care about them

playbooks/callback_plugins/hipchat_plugin.py

 import os
-import prettytable
-import hipchat
 import time
-import random
 from ansible import utils
+try:
+    import prettytable
+except ImportError:
+    prettytable = None
+try:
+    import hipchat
+except ImportError:
+    hipchat = None
 
 
 class CallbackModule(object):
@@ -24,8 +29,21 @@ class CallbackModule(object):
     """
 
     def __init__(self):
-
-        if 'HIPCHAT_TOKEN' in os.environ:
+        self.enabled = "HIPCHAT_TOKEN" in os.environ
+        if not self.enabled:
+            return
+
+        # make sure we got our imports
+        if not hipchat:
+            raise ImportError(
+                "The hipchat plugin requires the hipchat Python module, "
+                "which is not installed or was not found."
+            )
+        if not prettytable:
+            raise ImportError(
+                "The hipchat plugin requires the prettytable Python module, "
+                "which is not installed or was not found."
+            )
         self.start_time = time.time()
         self.task_report = []
         self.last_task = None
@@ -45,9 +63,6 @@ class CallbackModule(object):
         self.hipchat_msg_color = os.getenv('HIPCHAT_MSG_COLOR', '')
         self.printed_playbook = False
         self.playbook_name = None
-            self.enabled = True
-        else:
-            self.enabled = False
 
     def _send_hipchat(self, message, room=None, from_name=None, color=None, message_format='text'):
 

playbooks/callback_plugins/sqs.py

@@ -22,11 +22,12 @@ import time
 import json
 import socket
 try:
+    import boto
+except ImportError:
+    boto = None
+else:
     import boto.sqs
     from boto.exception import NoAuthHandlerFound
-except ImportError:
-    print "Boto is required for the sqs_notify callback plugin"
-    raise
 
 
 class CallbackModule(object):
@@ -47,11 +48,19 @@ class CallbackModule(object):
         - START events
     """
     def __init__(self):
+        self.enable_sqs = 'ANSIBLE_ENABLE_SQS' in os.environ
+        if not self.enable_sqs:
+            return
+
+        # make sure we got our imports
+        if not boto:
+            raise ImportError(
+                "The sqs callback module requires the boto Python module, "
+                "which is not installed or was not found."
+            )
 
         self.start_time = time.time()
 
-        if 'ANSIBLE_ENABLE_SQS' in os.environ:
-            self.enable_sqs = True
         if not 'SQS_REGION' in os.environ:
             print 'ANSIBLE_ENABLE_SQS enabled but SQS_REGION ' \
                   'not defined in environment'
@@ -75,8 +84,6 @@ class CallbackModule(object):
             self.prefix = ''
 
         self.last_seen_ts = {}
-        else:
-            self.enable_sqs = False
 
     def runner_on_failed(self, host, res, ignore_errors=False):
         if self.enable_sqs: