Use all caps for user creation vars.

playbooks/roles/common/tasks/create_github_users.yml

@@ -3,10 +3,10 @@
 # Overview:
 # 
 # Creates OS accounts for users based on their github credential.
-# Expects to find a list in scope named github_users with
+# Expects to find a list in scope named GITHUB_USERS with
 # the following structure:
 #
-# github_users:
+# GITHUB_USERS:
 #   - user: me_at_github
 #     groups:
 #     - adm
@@ -20,7 +20,7 @@
     name={{ item.user }} 
     groups={{ ",".join(item.groups) }}
     shell=/bin/bash
-  with_items: github_users
+  with_items: GITHUB_USERS
   tags:
     - users
     - update
@@ -29,7 +29,7 @@
   file: 
     path=/home/{{ item.user }}/.ssh state=directory mode=0700 
     owner={{ item.user }} group={{ item.user }}
-  with_items: github_users
+  with_items: GITHUB_USERS
   tags:
     - users
     - update
@@ -39,7 +39,7 @@
     url=https://github.com/{{ item.user }}.keys 
     dest=/home/{{ item.user }}/.ssh/authorized_keys mode=0600 
     owner={{ item.user }} group={{ item.user }}
-  with_items: github_users
+  with_items: GITHUB_USERS
   tags:
     - users
     - update

playbooks/roles/common/tasks/create_users.yml

@@ -36,8 +36,8 @@
 
 - name: common | Creating env users
   user: name={{ item.user }} {% if item.groups %}groups={{ ",".join(item.groups) }}{% endif %} shell=/bin/bash
-  with_items: env_users
-  when: env_users is defined
+  with_items: ENV_USERS
+  when: ENV_USERS is defined
   tags:
   - users
   - update

playbooks/roles/common/tasks/main.yml

 ---
 - include: create_users.yml
 - include: create_github_users.yml
-  when: github_users is defined
+  when: GITHUB_USERS is defined
 
 - name: common | Add user www-data
   # This user should be created on the system by default