Fix analytics-api name in new relic

The role name changed to analytics_api for consistency but this fixes the newrelic
name back to analytics-api as monitoring is already set up against this name

playbooks/roles/analytics_api/defaults/main.yml

@@ -33,6 +33,8 @@ analytics_api_code_dir: "{{ analytics_api_home }}/{{ analytics_api_service_name
 analytics_api_wsgi_name: "analyticsdataserver"
 analytics_api_hostname: "analytics-api"
 
+analytics_api_newrelic_appname: 'analytics-api'
+
 #
 # OS packages
 #

playbooks/roles/analytics_api/meta/main.yml

@@ -41,3 +41,4 @@ dependencies:
     edx_django_service_use_python3: false
     edx_django_service_wsgi_name: '{{ analytics_api_wsgi_name }}'
     edx_django_service_hostname: '~^((stage|prod)-)?{{ analytics_api_hostname }}.*'
+    edx_django_service_newrelic_appname: '{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-{{ analytics_api_newrelic_appname }}'