Merge pull request #3648 from edx/bjacobel/ecom-node-version

Pin nodeenv's node version to 6.9.4 LTS for Platform, Ecommerce, Insights and Credentials

playbooks/roles/common_vars/defaults/main.yml

@@ -98,6 +98,7 @@ COMMON_ENABLE_NEWRELIC_APP: False
 COMMON_ENABLE_MINOS: False
 COMMON_TAG_EC2_INSTANCE: False
 common_boto_version: '2.34.0'
+common_node_version: '6.9.4'
 common_redhat_pkgs:
   - ntp
   - lynx

playbooks/roles/credentials/defaults/main.yml

@@ -219,6 +219,7 @@ credentials_nodeenv_dir: "{{ credentials_home }}/nodeenvs/{{ credentials_service
 credentials_nodeenv_bin: "{{ credentials_nodeenv_dir }}/bin"
 credentials_node_modules_dir: "{{ credentials_code_dir }}/node_modules"
 credentials_node_bin: "{{ credentials_node_modules_dir }}/.bin"
+credentials_node_version: "{{ common_node_version }}"
 
 credentials_environment:
   DJANGO_SETTINGS_MODULE: "{{ CREDENTIALS_DJANGO_SETTINGS_MODULE }}"

playbooks/roles/credentials/tasks/main.yml

@@ -42,10 +42,19 @@
     - install
     - install:app-requirements
 
+# See https://github.com/ekalinin/nodeenv/issues/182
+# This can be removed once https://github.com/ekalinin/nodeenv/pull/183 is merged
+- name: Remove nodeenv src
+  file:
+    path: "{{ credentials_nodeenv_dir }}/src"
+    state: absent
+  become_user: "{{ credentials_user }}"
+  tags:
+    - install
+    - install:app-requirements
+
 - name: create nodeenv
-  shell: "{{ credentials_venv_dir }}/bin/nodeenv {{ credentials_nodeenv_dir }} --prebuilt"
-  args:
-    creates: "{{ credentials_nodeenv_dir }}"
+  shell: "{{ credentials_venv_dir }}/bin/nodeenv {{ credentials_nodeenv_dir }} --node={{ credentials_node_version }} --prebuilt --force"
   become_user: "{{ credentials_user }}"
   tags:
     - install

playbooks/roles/discovery/defaults/main.yml

@@ -241,7 +241,7 @@ discovery_nodeenv_dir: "{{ discovery_home }}/nodeenvs/{{ discovery_service_name
 discovery_nodeenv_bin: "{{ discovery_nodeenv_dir }}/bin"
 discovery_node_modules_dir: "{{ discovery_code_dir }}/node_modules"
 discovery_node_bin: "{{ discovery_node_modules_dir }}/.bin"
-discovery_node_version: "6.9.4"
+discovery_node_version: "{{ common_node_version }}"
 
 discovery_gunicorn_host: "127.0.0.1"
 discovery_gunicorn_port: 8381

playbooks/roles/discovery/tasks/main.yml

@@ -76,17 +76,30 @@
     - devstack
     - devstack:install
 
+# See https://github.com/ekalinin/nodeenv/issues/182
+# This can be removed once https://github.com/ekalinin/nodeenv/pull/183 is merged
+- name: Remove nodeenv src
+  file:
+    path: "{{ discovery_nodeenv_dir }}/src"
+    state: absent
+  become_user: "{{ discovery_user }}"
+  tags:
+    - install
+    - install:app-requirements
+
 - name: create nodeenv
-  shell: "{{ discovery_venv_dir }}/bin/nodeenv {{ discovery_nodeenv_dir }} --node={{ discovery_node_version }} --prebuilt"
-  args:
-    creates: "{{ discovery_nodeenv_dir }}"
+  shell: "{{ discovery_venv_dir }}/bin/nodeenv {{ discovery_nodeenv_dir }} --node={{ discovery_node_version }} --prebuilt --force"
   become_user: "{{ discovery_user }}"
   tags:
     - install
     - install:app-requirements
 
 - name: install node dependencies
-  npm: executable={{ discovery_nodeenv_bin }}/npm path={{ discovery_code_dir }} production=yes
+  npm:
+    executable: "{{ discovery_nodeenv_bin }}/npm"
+    path: "{{ discovery_code_dir }}"
+    production: yes
+    state: latest
   become_user: "{{ discovery_user }}"
   environment: "{{ discovery_environment }}"
   tags:

playbooks/roles/ecommerce/defaults/main.yml

@@ -214,6 +214,7 @@ ecommerce_nodeenv_dir: "{{ ecommerce_home }}/nodeenvs/{{ ecommerce_service_name
 ecommerce_nodeenv_bin: "{{ ecommerce_nodeenv_dir }}/bin"
 ecommerce_node_modules_dir: "{{ ecommerce_code_dir }}/node_modules"
 ecommerce_node_bin: "{{ ecommerce_node_modules_dir }}/.bin"
+ecommerce_node_version: "{{ common_node_version }}"
 
 ecommerce_gunicorn_host: "127.0.0.1"
 ecommerce_gunicorn_port: "8130"

playbooks/roles/ecommerce/tasks/main.yml

@@ -40,10 +40,19 @@
     - install
     - install:app-requirements
 
+# See https://github.com/ekalinin/nodeenv/issues/182
+# This can be removed once https://github.com/ekalinin/nodeenv/pull/183 is merged
+- name: Remove nodeenv src
+  file:
+    path: "{{ ecommerce_nodeenv_dir }}/src"
+    state: absent
+  become_user: "{{ ecommerce_user }}"
+  tags:
+    - install
+    - install:app-requirements
+
 - name: Create nodeenv
-  shell: "{{ ecommerce_venv_dir }}/bin/nodeenv {{ ecommerce_nodeenv_dir }} --prebuilt"
-  args:
-    creates: "{{ ecommerce_nodeenv_dir }}"
+  shell: "{{ ecommerce_venv_dir }}/bin/nodeenv {{ ecommerce_nodeenv_dir }} --node={{ ecommerce_node_version }} --prebuilt --force"
   become_user: "{{ ecommerce_user }}"
   tags:
     - install
@@ -54,6 +63,7 @@
     executable: "{{ ecommerce_nodeenv_bin }}/npm"
     path: "{{ ecommerce_code_dir }}"
     production: yes
+    state: latest
   become_user: "{{ ecommerce_user }}"
   environment: "{{ ecommerce_environment }}"
   tags:

playbooks/roles/edxapp/defaults/main.yml

@@ -642,7 +642,7 @@ edxapp_venv_bin: "{{ edxapp_venv_dir }}/bin"
 edxapp_nodeenv_dir: "{{ edxapp_app_dir }}/nodeenvs/edxapp"
 edxapp_nodeenv_bin: "{{ edxapp_nodeenv_dir }}/bin"
 edxapp_settings: '{{ EDXAPP_SETTINGS }}'
-edxapp_node_version: "6.9.2"
+edxapp_node_version: "{{ common_node_version }}"
 # This is where node installs modules, not node itself
 edxapp_node_bin: "{{ edxapp_code_dir }}/node_modules/.bin"
 edxapp_user: edxapp

playbooks/roles/edxapp/tasks/deploy.yml

@@ -210,10 +210,18 @@
     - install
     - install:app-requirements
 
+# See https://github.com/ekalinin/nodeenv/issues/182
+# This can be removed once https://github.com/ekalinin/nodeenv/pull/183 is merged
+- name: Remove nodeenv src
+  file:
+    path: "{{ edxapp_nodeenv_dir }}/src"
+    state: absent
+  tags:
+    - install
+    - install:app-requirements
+
 - name: create nodeenv
-  shell: "{{ edxapp_venv_dir }}/bin/nodeenv {{ edxapp_nodeenv_dir }} --node={{ edxapp_node_version }} --prebuilt"
-  args:
-    creates: "{{ edxapp_nodeenv_dir }}"
+  shell: "{{ edxapp_venv_dir }}/bin/nodeenv {{ edxapp_nodeenv_dir }} --node={{ edxapp_node_version }} --prebuilt --force"
   tags:
     - install
     - install:app-requirements
@@ -245,6 +253,7 @@
     executable: "{{ edxapp_nodeenv_bin }}/npm"
     path: "{{ edxapp_code_dir }}"
     production: yes
+    state: latest
   environment: "{{ edxapp_environment }}"
   become_user: "{{ edxapp_user }}"
   tags:

playbooks/roles/insights/defaults/main.yml

@@ -185,6 +185,7 @@ insights_nodeenv_dir: "{{ insights_home }}/nodeenvs/{{ insights_service_name }}"
 insights_nodeenv_bin: "{{ insights_nodeenv_dir }}/bin"
 insights_node_modules_dir: "{{ insights_code_dir }}/node_modules"
 insights_node_bin: "{{ insights_node_modules_dir }}/.bin"
+insights_node_version: "{{ common_node_version }}"
 
 insights_gunicorn_host: "127.0.0.1"
 insights_gunicorn_port: "8110"

playbooks/roles/insights/tasks/main.yml

@@ -44,17 +44,30 @@
     - install
     - install:app-requirements
 
+# See https://github.com/ekalinin/nodeenv/issues/182
+# This can be removed once https://github.com/ekalinin/nodeenv/pull/183 is merged
+- name: Remove nodeenv src
+  file:
+    path: "{{ insights_nodeenv_dir }}/src"
+    state: absent
+  become_user: "{{ insights_user }}"
+  tags:
+    - install
+    - install:app-requirements
+
 - name: create nodeenv
-  shell: "{{ insights_venv_dir }}/bin/nodeenv {{ insights_nodeenv_dir }}  --prebuilt"
-  args:
-    creates: "{{ insights_nodeenv_dir }}"
+  shell: "{{ insights_venv_dir }}/bin/nodeenv {{ insights_nodeenv_dir }}  --node={{ insights_node_version }} --prebuilt --force"
   become_user: "{{ insights_user }}"
   tags:
     - install
     - install:base
 
 - name: install node dependencies
-  npm: executable={{ insights_nodeenv_bin }}/npm path={{ insights_code_dir }} production=yes
+  npm:
+    executable: "{{ insights_nodeenv_bin }}/npm"
+    path: "{{ insights_code_dir }}"
+    production: yes
+    state: latest
   become_user: "{{ insights_user }}"
   tags:
     - install