Commit cb42a922 by Matjaz Gregoric

[TNL-6029] Remove role=button from items and zones.

The button role was misleading and is not needed.
parent 0a69b4c1
...@@ -66,7 +66,6 @@ function DragAndDropTemplates(configuration) { ...@@ -66,7 +66,6 @@ function DragAndDropTemplates(configuration) {
className += " grabbed-with-" + item.grabbed_with; className += " grabbed-with-" + item.grabbed_with;
} }
var attributes = { var attributes = {
'role': 'button',
'draggable': !item.drag_disabled, 'draggable': !item.drag_disabled,
'aria-grabbed': item.grabbed, 'aria-grabbed': item.grabbed,
'data-value': item.value, 'data-value': item.value,
...@@ -212,7 +211,6 @@ function DragAndDropTemplates(configuration) { ...@@ -212,7 +211,6 @@ function DragAndDropTemplates(configuration) {
'aria-dropeffect': 'move', 'aria-dropeffect': 'move',
'data-uid': zone.uid, 'data-uid': zone.uid,
'data-zone_align': zone.align, 'data-zone_align': zone.align,
'role': 'button',
'aria-describedby': zone_description_id, 'aria-describedby': zone_description_id,
}, },
style: { style: {
...@@ -221,8 +219,15 @@ function DragAndDropTemplates(configuration) { ...@@ -221,8 +219,15 @@ function DragAndDropTemplates(configuration) {
} }
}, },
[ [
h('p', { className: className }, zone.title), h(
h('p', { className: 'zone-description sr' }, zone.description || gettext("droppable")), 'p',
{ className: className },
[
zone.title,
h('span.sr', gettext(', dropzone'))
]
),
h('p', { className: 'zone-description sr' }, zone.description || gettext('droppable')),
h(item_wrapper, renderCollection(itemTemplate, items_in_zone, ctx)), h(item_wrapper, renderCollection(itemTemplate, items_in_zone, ctx)),
zone_description zone_description
] ]
...@@ -520,7 +525,6 @@ function DragAndDropTemplates(configuration) { ...@@ -520,7 +525,6 @@ function DragAndDropTemplates(configuration) {
item_bank_properties.attributes['tabindex'] = 0; item_bank_properties.attributes['tabindex'] = 0;
item_bank_properties.attributes['dropzone'] = 'move'; item_bank_properties.attributes['dropzone'] = 'move';
item_bank_properties.attributes['aria-dropeffect'] = 'move'; item_bank_properties.attributes['aria-dropeffect'] = 'move';
item_bank_properties.attributes['role'] = 'button';
} }
return ( return (
h('section.themed-xblock.xblock--drag-and-drop', [ h('section.themed-xblock.xblock--drag-and-drop', [
......
...@@ -142,7 +142,6 @@ class TestDragAndDropRender(BaseIntegrationTest): ...@@ -142,7 +142,6 @@ class TestDragAndDropRender(BaseIntegrationTest):
for index, item in enumerate(items): for index, item in enumerate(items):
item_number = index + 1 item_number = index + 1
self.assertEqual(item.get_attribute('role'), 'button')
self.assertEqual(item.get_attribute('tabindex'), '0') self.assertEqual(item.get_attribute('tabindex'), '0')
self.assertEqual(item.get_attribute('draggable'), 'true') self.assertEqual(item.get_attribute('draggable'), 'true')
self.assertEqual(item.get_attribute('aria-grabbed'), 'false') self.assertEqual(item.get_attribute('aria-grabbed'), 'false')
...@@ -194,7 +193,7 @@ class TestDragAndDropRender(BaseIntegrationTest): ...@@ -194,7 +193,7 @@ class TestDragAndDropRender(BaseIntegrationTest):
'#-Zone_{}'.format(zone_number), **zone_box_percentages '#-Zone_{}'.format(zone_number), **zone_box_percentages
) )
zone_name = zone.find_element_by_css_selector('p.zone-name') zone_name = zone.find_element_by_css_selector('p.zone-name')
self.assertEqual(zone_name.text, 'Zone {}'.format(zone_number)) self.assertEqual(zone_name.text, 'Zone {}\n, dropzone'.format(zone_number))
zone_description = zone.find_element_by_css_selector('p.zone-description') zone_description = zone.find_element_by_css_selector('p.zone-description')
self.assertEqual(zone_description.text, 'This describes zone {}'.format(zone_number)) self.assertEqual(zone_description.text, 'This describes zone {}'.format(zone_number))
# Zone description should only be visible to screen readers: # Zone description should only be visible to screen readers:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment