Commit c0c71ed6 by Matjaz Gregoric

Fix merge conflicts.

parent 93d306ac
...@@ -79,9 +79,7 @@ class ParameterizedTestsMixin(object): ...@@ -79,9 +79,7 @@ class ParameterizedTestsMixin(object):
overall_feedback = feedback['intro'] overall_feedback = feedback['intro']
expected_sr_texts.append(overall_feedback) expected_sr_texts.append(overall_feedback)
self.assert_reader_feedback_messages(expected_sr_texts) self.assert_reader_feedback_messages(expected_sr_texts)
if action_key: self._test_popup_focus_and_close(popup, action_key)
# Next TAB keypress should move focus to "Go to Beginning button"
self._test_next_tab_goes_to_go_to_beginning_button()
def parameterized_item_positive_feedback_on_good_move_assessment( def parameterized_item_positive_feedback_on_good_move_assessment(
self, items_map, scroll_down=100, action_key=None, feedback=None self, items_map, scroll_down=100, action_key=None, feedback=None
...@@ -104,6 +102,9 @@ class ParameterizedTestsMixin(object): ...@@ -104,6 +102,9 @@ class ParameterizedTestsMixin(object):
self.assertEqual(feedback_popup_html, '') self.assertEqual(feedback_popup_html, '')
self.assertFalse(popup.is_displayed()) self.assertFalse(popup.is_displayed())
self.assert_reader_feedback_messages([]) self.assert_reader_feedback_messages([])
if action_key:
# Next TAB keypress should move focus to "Go to Beginning button"
self._test_next_tab_goes_to_go_to_beginning_button()
def parameterized_item_negative_feedback_on_bad_move_standard( def parameterized_item_negative_feedback_on_bad_move_standard(
self, items_map, all_zones, scroll_down=100, action_key=None, feedback=None self, items_map, all_zones, scroll_down=100, action_key=None, feedback=None
...@@ -151,7 +152,6 @@ class ParameterizedTestsMixin(object): ...@@ -151,7 +152,6 @@ class ParameterizedTestsMixin(object):
self.assertFalse(popup.is_displayed()) self.assertFalse(popup.is_displayed())
self.assert_placed_item(definition.item_id, zone_title, assessment_mode=True) self.assert_placed_item(definition.item_id, zone_title, assessment_mode=True)
self.assert_reader_feedback_messages([]) self.assert_reader_feedback_messages([])
self._test_popup_focus_and_close(popup, action_key)
if action_key: if action_key:
self._test_next_tab_goes_to_go_to_beginning_button() self._test_next_tab_goes_to_go_to_beginning_button()
...@@ -380,6 +380,7 @@ class StandardInteractionTest(DefaultDataTestMixin, InteractionTestBase, Paramet ...@@ -380,6 +380,7 @@ class StandardInteractionTest(DefaultDataTestMixin, InteractionTestBase, Paramet
@data(*ITEM_DRAG_KEYBOARD_KEYS) @data(*ITEM_DRAG_KEYBOARD_KEYS)
def test_cannot_select_multiple_items(self, action_key): def test_cannot_select_multiple_items(self, action_key):
if action_key:
all_item_ids = self.items_map.keys() all_item_ids = self.items_map.keys()
# Go through all items and select them all using the keyboard action key. # Go through all items and select them all using the keyboard action key.
for item_id in all_item_ids: for item_id in all_item_ids:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment