Commit a7958491 by Filippo Valsorda

Fix do_attempt crash on incorrect tries

parent 002ae5a3
...@@ -170,10 +170,8 @@ class DragAndDropBlock(XBlock): ...@@ -170,10 +170,8 @@ class DragAndDropBlock(XBlock):
self.item_state[item['id']] = (attempt['top'], attempt['left']) self.item_state[item['id']] = (attempt['top'], attempt['left'])
if len(self.item_state) == tot_items: if len(self.item_state) == tot_items:
finished = True
final_feedback = self.data['feedback']['finish'] final_feedback = self.data['feedback']['finish']
else: else:
finished = False
final_feedback = None final_feedback = None
try: try:
...@@ -188,14 +186,14 @@ class DragAndDropBlock(XBlock): ...@@ -188,14 +186,14 @@ class DragAndDropBlock(XBlock):
return { return {
'correct': True, 'correct': True,
'finished': finished, 'finished': len(self.item_state) == tot_items,
'final_feedback': final_feedback, 'final_feedback': final_feedback,
'feedback': item['feedback']['correct'] 'feedback': item['feedback']['correct']
} }
else: else:
return { return {
'correct': False, 'correct': False,
'finished': finished, 'finished': len(self.item_state) == tot_items,
'final_feedback': None, 'final_feedback': None,
'feedback': item['feedback']['incorrect'] 'feedback': item['feedback']['incorrect']
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment