Skip to content

X
xblock-drag-and-drop-v2
Commit 82a02bc3 by Jonathan Piacenti
Options

Fix feedback clearing issues and extraneously fired events.

parent 574e1e68
Showing with 2 additions and 3 deletions
drag_and_drop_v2/public/js/drag_and_drop.js
...@@ -181,7 +181,7 @@ function DragAndDropBlock(runtime, element, configuration) { ...@@ -181,7 +181,7 @@ function DragAndDropBlock(runtime, element, configuration) {
}; };
truncateField(data, 'content'); truncateField(data, 'content');
publishEvent(data); publishEvent(data);
previousFeedback = undefined; delete state.feedback;
delete state.closing; delete state.closing;
} }
// Has feedback been set? // Has feedback been set?
...@@ -482,15 +482,14 @@ function DragAndDropBlock(runtime, element, configuration) { ...@@ -482,15 +482,14 @@ function DragAndDropBlock(runtime, element, configuration) {
} }
state.closing = true; state.closing = true;
previousFeedback = state.feedback;
if (target.is(close_button)) { if (target.is(close_button)) {
state.manually_closed = true; state.manually_closed = true;
previousFeedback = state.feedback;
} else { } else {
state.manually_closed = false; state.manually_closed = false;
} }
applyState(); applyState();
delete state.feedback;
}; };
var resetExercise = function(evt) { var resetExercise = function(evt) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment