Commit 01b33b96 by Matjaz Gregoric

Do not show completion checkmark when hide_feedback is enabled.

This makes the Completion block consistent with the Answer block.

When 'pb_hide_feedback_if_attempts_remain' is set to True in
XBLOCK_SETTINGS, once the user submits an answer to an Answer (freeform
long answer), the green checkmark is not visible after refreshing the
page, even though the given answer/text is still visible.

This commit makes Completion blocks consistent with that behaviour.
parent e620ce76
......@@ -16,11 +16,13 @@ function CompletionBlock(runtime, element) {
return $completion.is(':checked');
},
handleSubmit: function(result) {
handleSubmit: function(result, options) {
if (typeof result.submission !== 'undefined') {
this.updateCompletion(result);
if (!options.hide_results) {
$('.submit-result', element).css('visibility', 'visible');
}
}
},
handleReview: function(result) {
......
......@@ -32,6 +32,8 @@
<pb-tip values='["notwant"]'>Your loss!</pb-tip>
</pb-rating>
<pb-completion name="completion_1" question="Did you attend the meeting?" answer="Yes, I did." />
<pb-message type="completed">All Good</pb-message>
<pb-message type="incomplete">Not done yet</pb-message>
</problem-builder>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment