Merge pull request #73 from edx/cdodge/always-return-status-summary

fix when there is no attempt

edx_proctoring/api.py

@@ -848,7 +848,7 @@ def get_attempt_status_summary(user_id, course_id, content_id):
     attempt = get_exam_attempt(exam['id'], user_id)
     status = attempt['status'] if attempt else ProctoredExamStudentAttemptStatus.eligible
 
-    status_map = STATUS_SUMMARY_MAP if not attempt['is_sample_attempt'] else PRACTICE_STATUS_SUMMARY_MAP
+    status_map = STATUS_SUMMARY_MAP if not exam['is_practice_exam'] else PRACTICE_STATUS_SUMMARY_MAP
 
     summary = None
     if status in status_map:

edx_proctoring/tests/test_api.py

@@ -1317,7 +1317,7 @@ class ProctoredExamApiTests(LoggedInTestCase):
         Assert that we get the expected status summaries
         """
 
-        exam_attempt = self._create_started_exam_attempt(is_sample_attempt=True)
+        exam_attempt = self._create_started_practice_exam_attempt()
         update_attempt_status(
             exam_attempt.proctored_exam_id,
             self.user.id,
@@ -1366,9 +1366,7 @@ class ProctoredExamApiTests(LoggedInTestCase):
 
         set_runtime_service('credit', MockCreditService(enrollment_mode='honor'))
 
-        exam_attempt = self._create_started_exam_attempt(is_sample_attempt=True)
-        exam_attempt.proctored_exam.is_practice_exam = True
-        exam_attempt.proctored_exam.save()
+        exam_attempt = self._create_started_practice_exam_attempt()
 
         update_attempt_status(
             exam_attempt.proctored_exam_id,
@@ -1384,6 +1382,36 @@ class ProctoredExamApiTests(LoggedInTestCase):
 
         self.assertIn(summary, [expected])
 
+    def test_practice_no_attempt(self):
+        """
+        Assert that we get the expected status summaries
+        """
+
+        expected = {
+            'status': ProctoredExamStudentAttemptStatus.eligible,
+            'short_description': 'Ungraded Practice Exam',
+            'suggested_icon': 'fa-lock',
+            'in_completed_state': False
+        }
+
+        exam = get_exam_by_id(self.practice_exam_id)
+
+        set_runtime_service('credit', MockCreditService(enrollment_mode='honor'))
+        summary = get_attempt_status_summary(
+            self.user.id,
+            exam['course_id'],
+            exam['content_id']
+        )
+        self.assertIn(summary, [expected])
+
+        set_runtime_service('credit', MockCreditService())
+        summary = get_attempt_status_summary(
+            self.user.id,
+            exam['course_id'],
+            exam['content_id']
+        )
+        self.assertIn(summary, [expected])
+
     @ddt.data(
         'honor', 'staff'
     )