Commit 5b0d782e by Ricardo Kirkner

applied fixes per review

parent 3ebd1b44
...@@ -51,7 +51,7 @@ from django_openid_auth.exceptions import ( ...@@ -51,7 +51,7 @@ from django_openid_auth.exceptions import (
) )
USER_MODEL = get_user_model() User = get_user_model()
class OpenIDBackend: class OpenIDBackend:
...@@ -63,8 +63,8 @@ class OpenIDBackend: ...@@ -63,8 +63,8 @@ class OpenIDBackend:
def get_user(self, user_id): def get_user(self, user_id):
try: try:
return USER_MODEL.objects.get(pk=user_id) return User.objects.get(pk=user_id)
except USER_MODEL.DoesNotExist: except User.DoesNotExist:
return None return None
def authenticate(self, **kwargs): def authenticate(self, **kwargs):
...@@ -207,8 +207,8 @@ class OpenIDBackend: ...@@ -207,8 +207,8 @@ class OpenIDBackend:
# See if we already have this nickname assigned to a username # See if we already have this nickname assigned to a username
try: try:
USER_MODEL.objects.get(username__exact=nickname) User.objects.get(username__exact=nickname)
except USER_MODEL.DoesNotExist: except User.DoesNotExist:
# No conflict, we can use this nickname # No conflict, we can use this nickname
return nickname return nickname
...@@ -240,7 +240,7 @@ class OpenIDBackend: ...@@ -240,7 +240,7 @@ class OpenIDBackend:
pass pass
if getattr(settings, 'OPENID_STRICT_USERNAMES', False): if getattr(settings, 'OPENID_STRICT_USERNAMES', False):
if USER_MODEL.objects.filter(username__exact=nickname).count() > 0: if User.objects.filter(username__exact=nickname).count() > 0:
raise DuplicateUsernameViolation( raise DuplicateUsernameViolation(
"The username (%s) with which you tried to log in is " "The username (%s) with which you tried to log in is "
"already in use for a different account." % nickname) "already in use for a different account." % nickname)
...@@ -249,14 +249,14 @@ class OpenIDBackend: ...@@ -249,14 +249,14 @@ class OpenIDBackend:
# checking for conflicts. Start with number of existing users who's # checking for conflicts. Start with number of existing users who's
# username starts with this nickname to avoid having to iterate over # username starts with this nickname to avoid having to iterate over
# all of the existing ones. # all of the existing ones.
i = USER_MODEL.objects.filter(username__startswith=nickname).count() + 1 i = User.objects.filter(username__startswith=nickname).count() + 1
while True: while True:
username = nickname username = nickname
if i > 1: if i > 1:
username += str(i) username += str(i)
try: try:
USER_MODEL.objects.get(username__exact=username) User.objects.get(username__exact=username)
except USER_MODEL.DoesNotExist: except User.DoesNotExist:
break break
i += 1 i += 1
return username return username
...@@ -280,7 +280,7 @@ class OpenIDBackend: ...@@ -280,7 +280,7 @@ class OpenIDBackend:
username = self._get_available_username( username = self._get_available_username(
nickname, openid_response.identity_url) nickname, openid_response.identity_url)
user = USER_MODEL.objects.create_user(username, email, password=None) user = User.objects.create_user(username, email, password=None)
self.associate_openid(user, openid_response) self.associate_openid(user, openid_response)
self.update_user_details(user, details, openid_response) self.update_user_details(user, details, openid_response)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment