Respond to feedback

playbooks/roles/ecommerce/tasks/main.yml

@@ -135,18 +135,3 @@
     name={{ ecommerce_service_name }}
   when: not disable_edx_services
   sudo_user: "{{ supervisor_service_user }}"
-
-- name: create OAuth2 Client
-  shell: >
-    {{ COMMON_BIN_DIR }}/manage.edxapp lms --settings=aws
-    create_oauth2_client
-    "{{ ECOMMERCE_ECOMMERCE_URL_ROOT }}"
-    "{{ ECOMMERCE_ECOMMERCE_URL_ROOT }}/complete/edx-oidc/"
-    confidential
-    --client_name "{{ ecommerce_service_name }}"
-    --client_id "{{ ECOMMERCE_SOCIAL_AUTH_EDX_OIDC_KEY }}"
-    --client_secret "{{ ECOMMERCE_SOCIAL_AUTH_EDX_OIDC_SECRET }}"
-    --trusted
-  sudo_user: "{{ edxapp_user }}"
-  environment: "{{ edxapp_environment }}"
-  when: create_oauth2_clients

playbooks/roles/local_dev/defaults/main.yml

@@ -29,3 +29,7 @@ local_dev_pkgs:
     - openbox
 
 localdev_jscover_version: "1.0.2"
+
+localdev_oauth2_clients:
+    - { name: "{{ ecommerce_service_name }}", url_root: "{{ ECOMMERCE_ECOMMERCE_URL_ROOT }}",
+        id: "{{ ECOMMERCE_SOCIAL_AUTH_EDX_OIDC_KEY }}", secret: "{{ ECOMMERCE_SOCIAL_AUTH_EDX_OIDC_SECRET }}" }

playbooks/roles/local_dev/tasks/main.yml

@@ -76,3 +76,18 @@
 - name: add preview.localhost to /etc/hosts
   shell: sed -i -r 's/^127.0.0.1\s+.*$/127.0.0.1 localhost preview.localhost/' /etc/hosts
   sudo: yes
+
+- name: create OAuth2 Clients
+  shell: >
+    {{ COMMON_BIN_DIR }}/python.edxapp {{ COMMON_BIN_DIR }}/manage.edxapp lms --settings=aws
+    create_oauth2_client
+    {{ item.url_root }}
+    "{{ item.url_root }}/complete/edx-oidc/"
+    confidential
+    --client_name {{ item.name }}
+    --client_id {{ item.id }}
+    --client_secret {{ item.secret }}
+    --trusted
+  sudo_user: "{{ edxapp_user }}"
+  environment: "{{ edxapp_environment }}"
+  with_items: localdev_oauth2_clients

playbooks/vagrant-devstack.yml

@@ -8,7 +8,6 @@
     devstack: true
     disable_edx_services: true
     mongo_enable_journal: false
-    create_oauth2_clients: true
     EDXAPP_NO_PREREQ_INSTALL: 0
     COMMON_MOTD_TEMPLATE: 'devstack_motd.tail.j2'
     COMMON_SSH_PASSWORD_AUTH: "yes"