More review comments

playbooks/edx-east/analytics_pipeline.yml

-- name: Deploy all dependencies of edx-analytics-pipeline to the node
-  hosts: all
-  sudo: True
-  gather_facts: True
-  roles:
-    - analytics_pipeline

playbooks/roles/edx_ansible/templates/update.j2

@@ -12,7 +12,7 @@ IFS=","
             -v        add verbosity to edx_ansible run
             -h        this
 
-    <repo> - must be one of edx-platform, xqueue, cs_comments_service, xserver, ease, edx-ora, configuration, read-only-certificate-code, edx-analytics-data-api, insights, edx-analytics-pipeline
+    <repo> - must be one of edx-platform, xqueue, cs_comments_service, xserver, ease, edx-ora, configuration, read-only-certificate-code, edx-analytics-data-api
     <version> - can be a commit or tag
 
 EO
@@ -54,7 +54,6 @@ repos_to_cmd["read-only-certificate-code"]="$edx_ansible_cmd certs.yml -e 'certs
 repos_to_cmd["edx-analytics-data-api"]="$edx_ansible_cmd analyticsapi.yml -e 'ANALYTICS_API_VERSION=$2'"
 repos_to_cmd["edx-ora2"]="$edx_ansible_cmd ora2.yml -e 'ora2_version=$2'"
 repos_to_cmd["insights"]="$edx_ansible_cmd insights.yml -e 'INSIGHTS_VERSION=$2'"
-repos_to_cmd["edx-analytics-pipeline"]="$edx_ansible_cmd analytics_pipeline.yml"
 
 
 if [[ -z $1 || -z $2 ]]; then

playbooks/roles/hadoop_common/tasks/main.yml

@@ -24,8 +24,9 @@
 
 - name: install system packages
   apt: >
-    pkg={{ ','.join(hadoop_common_debian_pkgs) }}
+    pkg={{ item }}
     state=present
+  with_items: hadoop_common_debian_pkgs
 
 - name: ensure group exists
   group: name={{ hadoop_common_group }} system=yes state=present

vagrant/base/analyticstack/Vagrantfile

@@ -39,8 +39,8 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
   config.vm.network :forwarded_port, guest: 8765, host: 8765
   config.vm.network :forwarded_port, guest: 9200, host: 9200
   config.vm.network :forwarded_port, guest: 18080, host: 18080
-  config.vm.network :forwarded_port, guest: 8100, host: 8100  # Insights
-  config.vm.network :forwarded_port, guest: 8110, host: 8110  # Analytics Data API
+  config.vm.network :forwarded_port, guest: 8100, host: 8100  # Analytics Data API
+  config.vm.network :forwarded_port, guest: 8110, host: 8110  # Insights
   config.ssh.insert_key = true
 
   config.vm.synced_folder  ".", "/vagrant", disabled: true