- 28 Sep, 2015 17 commits
-
-
Re-order the methods in ssh.py so that methods needed for implementation are near and just above the relevant public methods. Standard with the rest of the code base.
Toshio Kuratomi committed -
Toshio Kuratomi committed
-
A couple of ssh cleanups
Toshio Kuratomi committed -
Make pipelining a connection variable
Toshio Kuratomi committed -
This is also peripheral to what _build_command needs, can be improved and tested independently, and so makes more sense in a separate method. This commit doesn't change any functionality (and I've verified that it works with the various combinations: control_path set in ansible.cfg, ssh_args adding or not adding ControlMaster/ControlPersist, etc.).
Abhijit Menon-Sen committed -
Toshio Kuratomi committed
-
Checking for sshpass is peripheral to the calling code, so it's easier to follow when the details are moved into a method.
Abhijit Menon-Sen committed -
Abhijit Menon-Sen committed
-
SSH pipelining can be a significant performance improvement, but it will not work if sudoers is configured to requiretty. With this change, one could have pipelining enabled in ansible.cfg, but use sudo to turn off requiretty in a separate play (or task) where pipelining is disabled: - hosts: foo vars: ansible_pipelining: no tasks: - lineinfile: dest=/etc/sudoers line='Defaults requiretty' state=absent sudo_user: root (Note that sudoers has a complicated syntax, so the above lineinfile invocation may be too simplistic for production use; but the point is that a separate play can do something to disable requiretty.)
Abhijit Menon-Sen committed -
Toshio Kuratomi committed
-
Toshio Kuratomi committed
-
James Cammarata committed
-
James Cammarata committed
-
Clarify why we add -q only for ssh
James Cammarata committed -
Python 3: the StringIO module is gone
James Cammarata committed -
Abhijit Menon-Sen committed
-
Fixes 17 failing tests on Python 3.4, restoring the 8 failures we had last Friday.
Marius Gedminas committed
-
- 27 Sep, 2015 1 commit
-
-
James Cammarata committed
-
- 26 Sep, 2015 15 commits
-
-
James Cammarata committed
-
Output proper JSON from vbox dynamic inventory contrib script
James Cammarata committed -
fix no self pointer out of class.
James Cammarata committed -
Also get pipelining working for people who look to chroot as an example for their own connection plugins Note: In the latest v2 API, action handles become but chroot doesn't reliably handle become. Maybe we need to add a has_become attribute that the action can display an appropriate error.
Toshio Kuratomi committed -
This can happen in chroot environments that don't have all of /proc available
Toshio Kuratomi committed -
Helps connection plugin implementors understand how to structure exec_command()
Toshio Kuratomi committed -
Ferry Boender committed
-
Fixes #12526
James Cammarata committed -
James Cammarata committed
-
Update outdated comment
Brian Coca committed -
Since #12165 was merged, hostnames are properly validated.
Abhijit Menon-Sen committed -
We now use "sudo -n" instead of "sudo -k && sudo …"
Abhijit Menon-Sen committed -
soarpenguin committed
-
soarpenguin committed
-
Clarified that .yml, .yaml, and .json are allowable file extensions for inventory vars files
Brian Coca committed
-
- 25 Sep, 2015 7 commits
-
-
James Cammarata committed
-
Brian Coca committed
-
Brian Coca committed
-
James Cammarata committed
-
Also strip UnsafeProxy off of low level srings and objects to ensure they don't cause issues later down the road Fixes #12513
James Cammarata committed -
James Cammarata committed
-
Toshio Kuratomi committed
-