Commit 34e25842 by Derek Carter

improved output in with_items fixes: #627

parent 8bb8314d
...@@ -248,22 +248,45 @@ class PlaybookRunnerCallbacks(DefaultRunnerCallbacks): ...@@ -248,22 +248,45 @@ class PlaybookRunnerCallbacks(DefaultRunnerCallbacks):
def on_unreachable(self, host, msg): def on_unreachable(self, host, msg):
item = msg.get('item', None)
if item:
print "fatal: [%s] => (item=%s) => %s" % (host, item, msg)
else:
print "fatal: [%s] => %s" % (host, msg) print "fatal: [%s] => %s" % (host, msg)
def on_failed(self, host, results): def on_failed(self, host, results):
item = results.get('item', None)
if item:
print "failed: [%s] => (item=%s) => %s" % (host, item, utils.jsonify(results))
else:
print "failed: [%s] => %s" % (host, utils.jsonify(results)) print "failed: [%s] => %s" % (host, utils.jsonify(results))
def on_ok(self, host, host_result): def on_ok(self, host, host_result):
item = host_result.get('item', None)
# show verbose output for non-setup module results if --verbose is used # show verbose output for non-setup module results if --verbose is used
if not self.verbose or host_result.get("verbose_override",None) is not None: if not self.verbose or host_result.get("verbose_override",None) is not None:
if item:
print "ok: [%s] => (item=%s)" % (host,item)
else:
print "ok: [%s]" % (host) print "ok: [%s]" % (host)
else: else:
if item:
print "ok: [%s] => (item=%s) => %s" % (host, item, utils.jsonify(host_result))
else:
print "ok: [%s] => %s" % (host, utils.jsonify(host_result)) print "ok: [%s] => %s" % (host, utils.jsonify(host_result))
def on_error(self, host, err): def on_error(self, host, err):
item = err.get('item', None)
if item:
print >>sys.stderr, "err: [%s] => (item=%s) => %s" % (host, item, err)
else:
print >>sys.stderr, "err: [%s] => %s" % (host, err) print >>sys.stderr, "err: [%s] => %s" % (host, err)
def on_skipped(self, host): def on_skipped(self, host):
......
...@@ -645,6 +645,7 @@ class Runner(object): ...@@ -645,6 +645,7 @@ class Runner(object):
self.callbacks.on_unreachable(host, result.result) self.callbacks.on_unreachable(host, result.result)
else: else:
data = result.result data = result.result
result.result['item'] = inject.get('item', None)
if 'skipped' in data: if 'skipped' in data:
self.callbacks.on_skipped(result.host) self.callbacks.on_skipped(result.host)
elif not result.is_successful(): elif not result.is_successful():
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment